Prototype version 2 to support NCCL zero copy #112241
Closed
minsii wants to merge 1 commit into
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112241
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit f35b398 with merge base 7f143d7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
reviewed
Oct 29, 2023
|
|
||
| void attachAllocatorTraceTracker(AllocatorTraceTracker tracker) { | ||
| enable_trace_tracker_ = true; | ||
| trace_trackers_.emplace_back(tracker); |
Collaborator
There was a problem hiding this comment.
Suggested change
| trace_trackers_.emplace_back(tracker); | |
| trace_trackers_.emplace_back(std::move(tracker)); |
ce3fff9 to
6379707
Compare
Contributor
Author
|
The cache allocator commit is reviewed via #112238 The intention of this PR is to test NCCL PG level change together with the cache allocator commit. |
0932427 to
bdb1a2e
Compare
Summary: We need to register all cache segments allocated by allocator, so that NCCL can apply zero copy algorithms at collective and point-to-point operations. How to track and register all cache segments: - It registers a register and a deregister hook to cache allocator as action tracker callbacks, tracking SEGMENT_ALLOC and SEGMENT_FREE trace entries, respectively. When SEGMENT_ALLOC is tracked, the register hook will register to the PG's communicators on the same device. Similarly, when SEGMENT_FREE is tracked, the deregister hook handles deregistration before cudaFree. - When a new NCCL communicator is created, it dumps the snapspot from cache allocator to register all existing cache segments at once. - When a NCCL communicator is aborted, it deregisters all segments that have been registered by this communicator Test Plan: See test in D50726971 Reviewed By: wconstab Differential Revision: D50726970
bdb1a2e to
f35b398
Compare
Contributor
Author
|
Close this prototype PR as the final version #112850 has exported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually port from D50726970 stack for OSS testing, not for review