[CPP] Update GCC minversion check to 9 or newer #120126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's already a requirement for building PyTorch, but should be a requirement for linking extensions with it, as that can lead to runtime crashes, as `std::optional` template layout is incompatible between gcc-9 and older compilers. Also, update minimum supported clang version to 10.x, as clang-5 is clearly not C++17 compliant Fixes #120020
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120126
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 7e45701 with merge base 637cf4a ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
approved these changes
Feb 16, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
to wangjiangben-hw/pytorch
that referenced
this pull request
Feb 22, 2024
It's already a requirement for building PyTorch, but should be a requirement for linking extensions with it, as that can lead to runtime crashes, as `std::optional` template layout is incompatible between gcc-9 and older compilers. Also, update minimum supported clang version to 9.x(used to build Android), as clang-5 is clearly not C++17 compliant. Fixes pytorch#120020 Pull Request resolved: pytorch#120126 Approved by: https://github.com/Skylion007
|
@pytorchbot cherry-pick --onto release/2.2 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Mar 7, 2024
It's already a requirement for building PyTorch, but should be a requirement for linking extensions with it, as that can lead to runtime crashes, as `std::optional` template layout is incompatible between gcc-9 and older compilers. Also, update minimum supported clang version to 9.x(used to build Android), as clang-5 is clearly not C++17 compliant. Fixes #120020 Pull Request resolved: #120126 Approved by: https://github.com/Skylion007 (cherry picked from commit 3ad067f)
Cherry picking #120126The cherry pick PR is at #121419 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
huydhn
pushed a commit
that referenced
this pull request
Mar 13, 2024
It's already a requirement for building PyTorch, but should be a requirement for linking extensions with it, as that can lead to runtime crashes, as `std::optional` template layout is incompatible between gcc-9 and older compilers. Also, update minimum supported clang version to 9.x(used to build Android), as clang-5 is clearly not C++17 compliant. Fixes #120020 Pull Request resolved: #120126 Approved by: https://github.com/Skylion007 (cherry picked from commit 3ad067f) Co-authored-by: Nikita Shulga <[email protected]>
|
Validated we no longer support gcc < 9 for release 2.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's already a requirement for building PyTorch, but should be a
requirement for linking extensions with it, as that can lead to runtime
crashes, as
std::optionaltemplate layout is incompatible betweengcc-9 and older compilers.
Also, update minimum supported clang version to 9.x(used to build Android), as clang-5 is clearly not C++17 compliant.
Fixes #120020
cc @jbschlosser