Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[dynamo] add more refleak tests #120657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[dynamo] add more refleak tests #120657

wants to merge 5 commits into from

Conversation

williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Feb 26, 2024 •
edited by pytorch-bot bot
Loading

williamwen42 added a commit that referenced this pull request Feb 26, 2024
@williamwen42
[dynamo] add more refleak tests
6a726b3 
ghstack-source-id: 9fc57a0
Pull Request resolved: #120657
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120657

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 2beb798 with merge base c66d68b (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@williamwen42
Update
b7b4944 
[ghstack-poisoned]
@williamwen42 williamwen42 mentioned this pull request Feb 28, 2024
Closed
@williamwen42
Update
69466d6 
[ghstack-poisoned]
@williamwen42
Update
49ace35 
[ghstack-poisoned]
@williamwen42
Update on "[dynamo] add more refleak tests"
2beb798 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@williamwen42
Copy link
Member Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 7, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@williamwen42 williamwen42 added the topic: not user facing topic category label Mar 7, 2024
@williamwen42
Copy link
Member Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda11_8-build / build

Details for Dev Infra team Raised by workflow job

@williamwen42
Copy link
Member Author

@pytorchbot merge -f "test fails on main"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Mar 8, 2024
@williamwen42 @facebook-github-bot
add more refleak tests (#120657)
b4a59da 
Summary:
X-link: pytorch/pytorch#120657
Approved by: https://github.com/jansel

Reviewed By: izaitsevfb

Differential Revision: D54661431

Pulled By: williamwen42

fbshipit-source-id: c934a2e5994727e266f4dcee946d2413a925848d
williamwen42 added a commit that referenced this pull request Mar 20, 2024
@williamwen42
Update base for Update on "[dynamo] use proxies to nn.Module in dynam…
985dd14 
…o generated GraphModules"


Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes #120631 (not entirely sure why)

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang aakhundov

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Mar 20, 2024
@williamwen42
Update on "[dynamo] use proxies to nn.Module in dynamo generated Grap…
7bb33b1 
…hModules"


Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes #120631 (not entirely sure why)

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang aakhundov

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Mar 21, 2024
@williamwen42 @pytorchmergebot
[dynamo] use proxies to nn.Module in dynamo generated GraphModules (#…
2352471 
…120756)

Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes some tests that xfail: #120631 (not entirely sure why), but introduced tests now fail.

Pull Request resolved: #120756
Approved by: https://github.com/jansel
facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Mar 22, 2024
@williamwen42 @facebook-github-bot
use proxies to nn.Module in dynamo generated GraphModules (#120756)
9d64293 
Summary:
Fixes remaining refleaks found when debugging pytorch/pytorch#119607, tests added in pytorch/pytorch#120657.

Also fixes some tests that xfail: pytorch/pytorch#120631 (not entirely sure why), but introduced tests now fail.

X-link: pytorch/pytorch#120756
Approved by: https://github.com/jansel

Reviewed By: huydhn

Differential Revision: D55225127

Pulled By: williamwen42

fbshipit-source-id: 0d402deb4246d981304985761b94f637970fabce
@github-actions github-actions bot deleted the gh/williamwen42/23/head branch April 7, 2024 01:53
pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
@williamwen42
[dynamo] use proxies to nn.Module in dynamo generated GraphModules (#…
6cec57d 
…120756)

Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes some tests that xfail: #120631 (not entirely sure why), but introduced tests now fail.

Pull Request resolved: #120756
Approved by: https://github.com/jansel
williamwen42 added a commit that referenced this pull request May 15, 2024
@williamwen42
[dynamo] use proxies to nn.Module in dynamo generated GraphModules (#…
3a08393 
…120756)

Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes some tests that xfail: #120631 (not entirely sure why), but introduced tests now fail.

Pull Request resolved: #120756
Approved by: https://github.com/jansel
@williamwen42 williamwen42 mentioned this pull request May 15, 2024
Merged
williamwen42 added a commit that referenced this pull request May 15, 2024
@williamwen42
[dynamo] use proxies to nn.Module in dynamo generated GraphModules (#…
40f60a6 
…120756)

Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes some tests that xfail: #120631 (not entirely sure why), but introduced tests now fail.

Pull Request resolved: #120756
Approved by: https://github.com/jansel
atalman pushed a commit that referenced this pull request May 22, 2024
@williamwen42
[dynamo] use proxies to nn.Module in dynamo generated GraphModules (#…
6cd59f1 
…126332)

* [dynamo] use proxies to nn.Module in dynamo generated GraphModules (#120756)

Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes some tests that xfail: #120631 (not entirely sure why), but introduced tests now fail.

Pull Request resolved: #120756
Approved by: https://github.com/jansel

* [dynamo] use proxies to nn.Module in dynamo generated GraphModules (#120756)

Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes some tests that xfail: #120631 (not entirely sure why), but introduced tests now fail.

Pull Request resolved: #120756
Approved by: https://github.com/jansel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@williamwen42 @pytorchmergebot @jansel