Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Include torch warn in each error in cudnn/Conv_v8.cpp #120719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Include torch warn in each error in cudnn/Conv_v8.cpp #120719

wants to merge 3 commits into from

Conversation

lancerts
Copy link
Contributor

Fixes #120702

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120719

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 61 Pending, 1 Unrelated Failure

As of commit d4fb4f0 with merge base d1510e0 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@lancerts lancerts changed the title Include torch warn in each error Include torch warn in each error in cudnn/Conv_v8.cpp Feb 27, 2024
@lancerts lancerts marked this pull request as ready for review February 27, 2024 17:07
@janeyx99 janeyx99 requested a review from eqy February 28, 2024 15:35
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 28, 2024
eqy
eqy reviewed Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@eqy eqy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, would it also be possible to add these changes to try_configs codepath, as that's the path that is actually run by default in most cases?

@lancerts
Copy link
Contributor Author

Thanks for the fix, would it also be possible to add these changes to try_configs codepath, as that's the path that is actually run by default in most cases?

Sure, it is added.

@lancerts lancerts requested a review from eqy February 28, 2024 22:53
eqy
eqy previously approved these changes Feb 28, 2024
View reviewed changes
@eqy
Copy link
Collaborator

eqy commented Feb 29, 2024

CC @atalman for review

@lancerts
Copy link
Contributor Author

lancerts commented Mar 7, 2024

@malfet @atalman can you help the review? Thanks

@lancerts
Copy link
Contributor Author

lancerts commented Mar 11, 2024 •
edited
Loading

@janeyx99 ty

janeyx99
janeyx99 previously approved these changes Mar 11, 2024
View reviewed changes
@janeyx99
Copy link
Contributor

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 11, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix-120702 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix-120702 && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@janeyx99 janeyx99 added the release notes: cuda release notes category label Mar 11, 2024
@janeyx99
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@janeyx99
Copy link
Contributor

@pytorchbot revert -c weird -m "sorry but am reverting as this prints unwanted warnings even when an exception is not thrown "

It would be better if the warnings only gave more color to an already-gonna-be-thrown exception vs when the program will continue safely

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Mar 13, 2024
@pytorchmergebot
Revert "Include torch warn in each error in cudnn/Conv_v8.cpp (#120719)"
51cf57c 
This reverts commit 5fd7f5c.

Reverted #120719 on behalf of https://github.com/janeyx99 due to sorry but am reverting as this prints unwanted warnings even when an exception is not thrown  ([comment](#120719 (comment)))
@pytorchmergebot
Copy link
Collaborator

@lancerts your PR has been successfully reverted.

@pytorch-bot pytorch-bot bot dismissed stale reviews from eqy and janeyx99 March 13, 2024 14:09

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@eqy eqy mentioned this pull request Apr 26, 2024
Closed
eqy pushed a commit to eqy/pytorch that referenced this pull request May 8, 2024
@pytorchmergebot @eqy
Revert "Include torch warn in each error in cudnn/Conv_v8.cpp (pytorc…
27a801b 
…h#120719)"

This reverts commit 5fd7f5c.

Reverted pytorch#120719 on behalf of https://github.com/janeyx99 due to sorry but am reverting as this prints unwanted warnings even when an exception is not thrown  ([comment](pytorch#120719 (comment)))
@eqy eqy mentioned this pull request May 8, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label May 12, 2024
atalman pushed a commit that referenced this pull request May 13, 2024
@eqy @pytorchmergebot
Revert "Include torch warn in each error in cudnn/Conv_v8.cpp (#120719)…
2e165ec 
…" (#125790)

This reverts commit 5fd7f5c.

Reverted #120719 on behalf of https://github.com/janeyx99 due to sorry but am reverting as this prints unwanted warnings even when an exception is not thrown  ([comment](#120719 (comment)))

Co-authored-by: PyTorch MergeBot <[email protected]>
@github-actions github-actions bot closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eqy eqy eqy left review comments

@janeyx99 janeyx99 janeyx99 left review comments

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: cuda release notes category Reverted Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uninformative errors in cudnn/Conv_v8.cpp

5 participants

@lancerts @eqy @janeyx99 @pytorchmergebot @pytorchbot