Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove support for c extensions#12122

Closed
li-roy wants to merge 1 commit into
pytorch:masterfrom
li-roy:export-D10060541
Closed

remove support for c extensions#12122
li-roy wants to merge 1 commit into
pytorch:masterfrom
li-roy:export-D10060541

Conversation

@li-roy
Copy link
Copy Markdown
Contributor

@li-roy li-roy commented Sep 27, 2018

Summary: We are deprecating support for c extensions. Please use cpp extension in the future.

Differential Revision: D10060541

Copy link
Copy Markdown
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end of an era

@ssnl
Copy link
Copy Markdown
Collaborator

ssnl commented Sep 27, 2018

Could you still keep torch/utils/ffi/__init__.py and make it just throw deprecation error?

Summary:
Pull Request resolved: pytorch#12122

We are deprecating support for c extensions. Please use cpp extension in the future.

Differential Revision: D10060541

fbshipit-source-id: 800434b10b27e32978d5f15b0a99636d6f4083d9
@ssnl
Copy link
Copy Markdown
Collaborator

ssnl commented Sep 28, 2018

Thanks!

@ruotianluo
Copy link
Copy Markdown
Contributor

This breaking change is not in the release doc.

@ezyang ezyang added the merged label Jun 26, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#12122

We are deprecating support for c extensions. Please use cpp extension in the future.

Reviewed By: Yangqing

Differential Revision: D10060541

fbshipit-source-id: 4f7149e06a254bd7af463fd7aa9740f65369963a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants