Fix MSVC 14.38 - VS 2022 Build #122120

pytorchbot · 2024-03-18T19:39:23Z

This PR is prepared to separate existing #116926 and to apply suggestions in the review.

scalar_t which is defined as c10::impl::ScalarTypeToCPPType<ScalarType::Half>::t appears to be causing the issue with Visual Studio 2022 17.8.4 (coming with MSVC 14.38.33130)

Error message:

aten\src\ATen/cpu/vec/vec_base.h(150): fatal error C1001: Internal compiler error.
(compiler file 'D:\a_work\1\s\src\vctools\Compiler\CxxFE\sl\p1\c\toinil.c', line 910)

Related line was added for a similar issue before as a workaround (scalar_t definition) Fix compile error for vs2022

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @vladimir-aubrecht @iremyux @Blackhex @cristianPanaite @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

Fixes #115922 This PR is prepared to separate existing #116926 and to apply suggestions in the review. `scalar_t` which is defined as `c10::impl::ScalarTypeToCPPType<ScalarType::Half>::t` appears to be causing the issue with `Visual Studio 2022 17.8.4` (coming with `MSVC 14.38.33130`) Error message: ``` aten\src\ATen/cpu/vec/vec_base.h(150): fatal error C1001: Internal compiler error. (compiler file 'D:\a_work\1\s\src\vctools\Compiler\CxxFE\sl\p1\c\toinil.c', line 910) ``` --- Related line was added for a similar issue before as a workaround (`scalar_t` definition) [Fix compile error for vs2022](#85958) Pull Request resolved: #117497 Approved by: https://github.com/ezyang, https://github.com/malfet (cherry picked from commit fa86fa7)

pytorch-bot · 2024-03-18T19:39:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122120

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures, 28 Unrelated Failures

As of commit 64de554 with merge base a8bd593 ():

NEW FAILURES - The following jobs have failed:

pull / linux-focal-py3.11-clang10 / test (crossref, 1, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (default, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (default, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (crossref, 1, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (crossref, 2, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (default, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (dynamo, 1, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 2, linux.2xlarge) (gh)
pull / linux-jammy-py3.8-gcc11 / test (default, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (default, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (distributed, 2, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, linux.8xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 2, 3, linux.8xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 3, 3, linux.8xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 1, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 2, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 3, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 4, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 5, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 3, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 4, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3_8-clang9-xla / build (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (crossref, 2, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (default, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (dynamo, 1, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (dynamo, 2, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (default, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (default, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 1, 6, linux.4xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 2, 6, linux.4xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 3, 6, linux.4xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 4, 6, linux.4xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 5, 6, linux.4xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 6, 6, linux.4xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (default, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (distributed, 1, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorchbot mentioned this pull request Mar 18, 2024

Fix MSVC 14.38 - VS 2022 Build #117497

Closed

pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Mar 18, 2024

pytorchbot added the open source label Mar 18, 2024

atalman mentioned this pull request Mar 18, 2024

[v2.2.2] Release Tracker #120999

Closed

atalman approved these changes Mar 18, 2024

View reviewed changes

atalman merged commit 13a5142 into release/2.2 Mar 18, 2024

boyu-chen-intern mentioned this pull request Mar 21, 2024

source build for fails for ipex on windows 11 intel/intel-extension-for-pytorch#474

Closed

juliagmt-google mentioned this pull request Mar 25, 2024

Add a function to find missing cherry picks in different branches pytorch/builder#1752

Merged

github-actions bot deleted the cherry-pick-117497-by-pytorch_bot_bot_ branch April 18, 2024 01:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix MSVC 14.38 - VS 2022 Build #122120

Fix MSVC 14.38 - VS 2022 Build #122120

Uh oh!

pytorchbot commented Mar 18, 2024

Uh oh!

pytorch-bot bot commented Mar 18, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix MSVC 14.38 - VS 2022 Build #122120

Fix MSVC 14.38 - VS 2022 Build #122120

Uh oh!

Conversation

pytorchbot commented Mar 18, 2024

Uh oh!

pytorch-bot bot commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122120

❌ 11 New Failures, 28 Unrelated Failures

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pytorch-bot bot commented Mar 18, 2024 •

edited

Loading