Restore DILL_AVAILABLE for backwards compat with torchdata #122616

ezyang · 2024-03-25T16:41:11Z

Stack from ghstack (oldest at bottom):

-> Restore DILL_AVAILABLE for backwards compat with torchdata #122616

Signed-off-by: Edward Z. Yang [email protected]

cc @albanD

[ghstack-poisoned]

pytorch-bot · 2024-03-25T16:41:14Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122616

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit dce7bc2 with merge base failed to retrieve merge base, please contact dev infra:

NEW FAILURE - The following job has failed:

pull / before-test / llm-retrieval (gh)
Process completed with exit code 1.

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-focal-py3_8-clang9-xla / test (xla, 1, 1, linux.12xlarge) (gh)
Process completed with exit code 128.
trunk / before-test / llm-retrieval (gh)
Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

torch/utils/data/datapipes/utils/common.py

[ghstack-poisoned]

Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: d3c295c Pull Request resolved: #122616

ezyang · 2024-03-25T20:58:11Z

@pytorchbot merge -i

pytorchmergebot · 2024-03-25T20:59:58Z

Merge started

Your change will be merged while ignoring the following 2 checks: pull / before-test / llm-retrieval, trunk / before-test / llm-retrieval

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-03-25T21:36:51Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

.github/workflows/pull.yml / before-test / llm-retrieval

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

ezyang · 2024-03-26T01:28:54Z

@pytorchbot merge -i

pytorchmergebot · 2024-03-26T01:30:42Z

Merge started

Your change will be merged while ignoring the following 3 checks: .github/workflows/pull.yml / before-test / llm-retrieval, .github/workflows/pull.yml / linux-focal-py3_8-clang9-xla / test (xla, 1, 1, linux.12xlarge), .github/workflows/trunk.yml / before-test / llm-retrieval

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-03-26T01:36:06Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / before-test / llm-retrieval

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

peterbell10 · 2024-03-26T02:16:32Z

@pytorchbot merge -f "Unrelated failure"

pytorchmergebot · 2024-03-26T02:18:24Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #122616 Approved by: https://github.com/peterbell10

Rhett-Ying · 2024-05-08T06:24:29Z

Is there any workaround for this issue if working with torch 2.3.0?

albanD · 2024-05-08T13:23:49Z

I would expect that you can work around this by doing the imports this way, not ideal though:

import torch
torch.utils.data.datapipes.utils.common.DILL_AVAILABLE = torch.utils._import_utils.dill_available()
import torchdata

Atul-1992 · 2024-05-11T11:10:35Z

Thanks, It worked!

atalman · 2024-05-13T19:57:27Z

@pytorchbot cherry-pick --onto release/2.3 -c regression --fixes #124907

Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #122616 Approved by: https://github.com/peterbell10 (cherry picked from commit f428183)

pytorchbot · 2024-05-13T20:01:32Z

Cherry picking #122616

The cherry pick PR is at #126094 and it is linked with issue #124907

Details for Dev Infra team

Raised by workflow job

Restore DILL_AVAILABLE for backwards compat with torchdata (#122616) Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #122616 Approved by: https://github.com/peterbell10 (cherry picked from commit f428183) Co-authored-by: Edward Z. Yang <[email protected]>

sarikasaxena30 · 2024-06-06T07:06:58Z

FileNotFoundError: Cannot find DGL C++ graphbolt library at /usr/local/lib/python3.10/dist-packages/dgl/graphbolt/libgraphbolt_pytorch_2.3.0.so
How to solve this problem?anyone can help me in this

Update

623c2ab

[ghstack-poisoned]

ezyang requested a review from ejguan as a code owner March 25, 2024 16:41

pytorch-bot bot added the release notes: dataloader release notes category label Mar 25, 2024

github-actions bot requested review from SherlockNoMad, albanD, antoniojkim, bdhirsh and miladm March 25, 2024 16:41

ezyang requested review from peterbell10 and removed request for SherlockNoMad, albanD, antoniojkim, bdhirsh and miladm March 25, 2024 16:41

ezyang added ciflow/trunk Trigger trunk jobs on your pull request topic: bug fixes topic category module: python frontend For issues relating to PyTorch's Python frontend labels Mar 25, 2024

peterbell10 reviewed Mar 25, 2024

View reviewed changes

torch/utils/data/datapipes/utils/common.py Outdated Show resolved Hide resolved

Update

dce7bc2

[ghstack-poisoned]

ezyang added a commit that referenced this pull request Mar 25, 2024

Restore DILL_AVAILABLE for backwards compat with torchdata

8539dd6

Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: d3c295c Pull Request resolved: #122616

peterbell10 approved these changes Mar 25, 2024

View reviewed changes

pytorchmergebot added the merging label Mar 25, 2024

pytorchmergebot removed the merging label Mar 25, 2024

pytorchmergebot added the merging label Mar 26, 2024

pytorchmergebot removed the merging label Mar 26, 2024

pytorchmergebot added the merging label Mar 26, 2024

pytorchmergebot closed this in f428183 Mar 26, 2024

pytorchmergebot added Merged and removed merging labels Mar 26, 2024

pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024

Restore DILL_AVAILABLE for backwards compat with torchdata (#122616)

5b15b40

Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #122616 Approved by: https://github.com/peterbell10

This was referenced Apr 25, 2024

mistake chanzuckerberg/cellxgene-census#1110

Closed

torchdata not compatible with torch 2.3.0 meta-pytorch/data#1244

Open

malfet added this to the 2.3.1 milestone Apr 25, 2024

Rhett-Ying mentioned this pull request May 8, 2024

[torchdata] cannot import name 'DILL_AVAILABLE' from 'torch.utils.data.datapipes.utils.common' dmlc/dgl#7380

Closed

pytorchbot mentioned this pull request May 13, 2024

Restore DILL_AVAILABLE for backwards compat with torchdata #126094

Merged

This was referenced May 13, 2024

[v2.3.1] Release Tracker #125425

Closed

2.3.0 not backward compatible with torchdata #124907

Closed

ebezzi mentioned this pull request Jun 6, 2024

[python] Remove pytorch pin chanzuckerberg/cellxgene-census#1190

Merged

github-actions bot deleted the gh/ezyang/2633/head branch July 7, 2024 01:59

Restore DILL_AVAILABLE for backwards compat with torchdata #122616

Restore DILL_AVAILABLE for backwards compat with torchdata #122616

Uh oh!

Conversation

ezyang commented Mar 25, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122616

❌ 1 New Failure, 2 Unrelated Failures

Uh oh!

Uh oh!

ezyang commented Mar 25, 2024

Uh oh!

pytorchmergebot commented Mar 25, 2024

Merge started

Uh oh!

pytorchmergebot commented Mar 25, 2024

Merge failed

Uh oh!

ezyang commented Mar 26, 2024

Uh oh!

pytorchmergebot commented Mar 26, 2024

Merge started

Uh oh!

pytorchmergebot commented Mar 26, 2024

Merge failed

Uh oh!

peterbell10 commented Mar 26, 2024

Uh oh!

pytorchmergebot commented Mar 26, 2024

Merge started

Uh oh!

Rhett-Ying commented May 8, 2024

Uh oh!

albanD commented May 8, 2024

Uh oh!

Atul-1992 commented May 11, 2024

Uh oh!

atalman commented May 13, 2024

Uh oh!

pytorchbot commented May 13, 2024

Cherry picking #122616

Uh oh!

sarikasaxena30 commented Jun 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

ezyang commented Mar 25, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Mar 25, 2024 •

edited

Loading