[RFC][FSDP2] Renamed FSDP to FSDPModule
#124936
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124936
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit fdb1808 with merge base c82fcb7 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
FSDP to FSDPModuleFSDP to FSDPModule
mvpatel2000
reviewed
Apr 25, 2024
|
@mvpatel2000 Sounds good. I can leave it as is. |
|
@mvpatel2000 I did not realize you guys were already looking at FSDP2 😅 |
Ah sorry! I missed that this is FSDP2. We haven't yet switched, so I think this PR is fine :). IIRC it isnt in the last stable release yet, so BC breaking changes are OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
FSDPtoFSDPModule#124936DeviceMesh.from_group()#124787.to(cpu)#124768This PR renames the
FSDPclass toFSDPModule. This is a BC breaking change. The rationale is thatFSDPModuleis more descriptive sincefully_shardis a module-level API (applied to amodulearg), so theFSDPclass will always correspond to a module.cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k