[RFC][FSDP2] Renamed FSDP to FSDPModule
#124955
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124955
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 93cf3c1 with merge base c82fcb7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
wanchaol
approved these changes
Apr 26, 2024
| cls = module.__class__ | ||
| dct = {"__deepcopy__": unimplemented_deepcopy} | ||
| new_cls = type(f"FSDP{cls.__name__}", (FSDP, cls), dct) | ||
| new_cls = type(f"FSDP{cls.__name__}", (FSDPModule, cls), dct) |
There was a problem hiding this comment.
This won't affect the __repr__ of the wrapped class iiuc?
There was a problem hiding this comment.
I think it should not.
|
cc: @wconstab If we land this change, then I think we need to change the PiPPy code to migrate |
wconstab
approved these changes
Apr 29, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Apr 29, 2024
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
This PR renames the `FSDP` class to `FSDPModule`. This is a BC breaking change. The rationale is that `FSDPModule` is more descriptive since `fully_shard` is a module-level API (applied to a `module` arg), so the `FSDP` class will always correspond to a module. Also, users commonly import `FullyShardedDataParallel` as `FSDP`, so this can help avoid some name conflict in some cases. Pull Request resolved: #124955 Approved by: https://github.com/wanchaol, https://github.com/wconstab ghstack dependencies: #124651, #124741, #124767, #124768, #124780, #124787
|
oops. now I will use try-except in TorchTune to import FSDPModule |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
FSDPtoFSDPModule#124955DeviceMesh.from_group()#124787.to(cpu)#124768This PR renames the
FSDPclass toFSDPModule. This is a BC breaking change. The rationale is thatFSDPModuleis more descriptive sincefully_shardis a module-level API (applied to amodulearg), so theFSDPclass will always correspond to a module.Also, users commonly import
FullyShardedDataParallelasFSDP, so this can help avoid some name conflict in some cases.cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k