[dynamo] fix 3.11+ refleak #126107
Closed
[dynamo] fix 3.11+ refleak #126107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #119607 for 3.11+. In 3.11+, `_PyFrame_FastToLocalsWithError` could implicity run `COPY_FREE_VARS` on the original frame, leading to double incref's since the dynamo shadow frame can rerun `COPY_FREE_VARS`. So the solution is to skip the first `COPY_FREE_VARS` instruction in the shadow frame if it was already executed in the original frame. Also move the location for clearing the original frame in 3.12 to handle error cases more thoroughly. Pull Request resolved: #124238 Approved by: https://github.com/jansel (cherry picked from commit 812bae0)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126107
Note: Links to docs will display an error until the docs builds have been completed. ❌ 26 New FailuresAs of commit 6f59330 with merge base 86a2d67 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This also requires cherry picking 2564f6c, I will try to reuse this cherry pick to get that commit too |
|
not - required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #119607 for 3.11+.
In 3.11+,
_PyFrame_FastToLocalsWithErrorcould implicity runCOPY_FREE_VARSon the original frame, leading to double incref's since the dynamo shadow frame can rerunCOPY_FREE_VARS. So the solution is to skip the firstCOPY_FREE_VARSinstruction in the shadow frame if it was already executed in the original frame.Also move the location for clearing the original frame in 3.12 to handle error cases more thoroughly.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang