Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Cherry-pick][DCP][AC] Add test for apply AC with FSDP1 (#126935) #126992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024
+20 −1
Merged

[Cherry-pick][DCP][AC] Add test for apply AC with FSDP1 (#126935) #126992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion test/distributed/checkpoint/test_state_dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ def is_cpu(v):

@with_comms
@skip_if_lt_x_gpu(1)
def test_activation_ckpt_fqns(self) -> None:
def test_activation_ckpt_fqns_ddp(self) -> None:
"""Tests that activation checkpointing prefixes are removed from module names"""
model = CompositeParamModel(device=torch.device("cuda"))
original_keys = get_model_state_dict(model).keys()
Expand All @@ -517,6 +517,25 @@ def test_activation_ckpt_fqns(self) -> None:

self.assertEqual(original_keys, new_keys)

@with_comms
@skip_if_lt_x_gpu(1)
def test_activation_ckpt_fqns_fsdp1(self) -> None:
self.run_subtests(
{"use_orig_params": [True, False]},
self._test_activation_ckpt_fqns_fsdp1,
)

def _test_activation_ckpt_fqns_fsdp1(self, use_orig_params: bool) -> None:
"""Tests that activation checkpointing prefixes are removed from module names"""
model = CompositeParamModel(device=torch.device("cuda"))
original_keys = get_model_state_dict(model).keys()

apply_activation_checkpointing(model)
model = FSDP(model, use_orig_params=use_orig_params)
new_keys = get_model_state_dict(model).keys()

self.assertEqual(original_keys, new_keys)


if __name__ == "__main__":
run_tests()