-
Notifications
You must be signed in to change notification settings - Fork 24.1k
Fix warnings and simplify code in TensorShape #141971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141971
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ffef951 with merge base d89c7ea ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "topic: not user facing" |
351948e
to
8cd3753
Compare
There's a lot of reformatting changes that make it difficult to review. Is it possible to do the reformatting separately? |
87e4893
to
b20935c
Compare
@ezyang Formatting was merged as a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm by no mean a c++ expert but this is a quite critical file so want to be extra careful and explicit about everything in it.
@cyyever FYI, I'm going on parental leave for four months at the end of january, so I'm not going to be working on merging PRs like this in my last two weeks. Hopefully you can find other reviewers. |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Fixes #ISSUE_NUMBER