Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix warnings and simplify code in TensorShape #141971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Dec 3, 2024

Fixes #ISSUE_NUMBER

Copy link

pytorch-bot bot commented Dec 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141971

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ffef951 with merge base d89c7ea (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever
Copy link
Collaborator Author

cyyever commented Dec 4, 2024

@pytorchbot label "topic: not user facing"

@cyyever cyyever marked this pull request as ready for review December 4, 2024 02:42
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 4, 2024
@cyyever cyyever marked this pull request as draft December 4, 2024 05:05
@cyyever cyyever force-pushed the attention branch 4 times, most recently from 351948e to 8cd3753 Compare December 5, 2024 02:32
@cyyever cyyever requested a review from ezyang December 8, 2024 13:23
@cyyever cyyever marked this pull request as ready for review December 8, 2024 13:25
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 9, 2024
@ezyang
Copy link
Contributor

ezyang commented Dec 11, 2024

There's a lot of reformatting changes that make it difficult to review. Is it possible to do the reformatting separately?

@cyyever cyyever marked this pull request as draft December 12, 2024 11:23
@cyyever cyyever force-pushed the attention branch 2 times, most recently from 87e4893 to b20935c Compare December 13, 2024 01:05
@cyyever cyyever marked this pull request as ready for review December 13, 2024 06:00
@cyyever
Copy link
Collaborator Author

cyyever commented Dec 13, 2024

@ezyang Formatting was merged as a separate PR.

@cyyever cyyever requested a review from albanD December 19, 2024 13:25
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm by no mean a c++ expert but this is a quite critical file so want to be extra careful and explicit about everything in it.

@ezyang
Copy link
Contributor

ezyang commented Jan 14, 2025

@cyyever FYI, I'm going on parental leave for four months at the end of january, so I'm not going to be working on merging PRs like this in my last two weeks. Hopefully you can find other reviewers.

@ezyang ezyang removed their request for review January 14, 2025 16:07
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Apr 3, 2025
@github-actions github-actions bot closed this May 3, 2025
@cyyever cyyever reopened this May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open source Stale topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants