[BE] - Remove conda test and upload scripts and env variables from Workflows Part 1#144870
Closed
atalman wants to merge 2 commits into
Closed
[BE] - Remove conda test and upload scripts and env variables from Workflows Part 1#144870atalman wants to merge 2 commits into
atalman wants to merge 2 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144870
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 36 Pending, 7 Unrelated FailuresAs of commit 67c96a5 with merge base f314522 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Jan 15, 2025
Contributor
malfet
left a comment
There was a problem hiding this comment.
Deleted code is tested code :)
Collaborator
Author
|
Check Binary failures are note related, but need to be fixed. |
42722d2 to
67c96a5
Compare
Collaborator
Author
|
@pytorchmergebot merge -f "xpu and executorch failures are not related" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 17, 2025
Continuation of #144870 Remove conda logic from scripts: 1. Remove conda build from triton build script 2. Remove conda checks from setup.py 3. Remove conda from release scripts 4. Script read_conda_versions.sh is not used (checked via git grep) Related to: #138506 Pull Request resolved: #145015 Approved by: https://github.com/malfet, https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove conda test and upload scripts and env variables from Workflows
Related to: #138506