Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix clang-tidy warnings in torch/jit #147253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix clang-tidy warnings in torch/jit #147253

wants to merge 2 commits into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Feb 15, 2025 •
edited by pytorch-bot bot
Loading

Fixes #ISSUE_NUMBER

cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147253

Note: Links to docs will display an error until the docs builds have been completed.

❌ 20 New Failures, 1 Unrelated Failure

As of commit a70df99 with merge base 83acb68 (image):

NEW FAILURES - The following jobs have failed:

  • Lint / Link checks / Lint URLs / linux-job (gh)
    RuntimeError: Command docker exec -t 82ee98a8944afaa0c4a8fc44cf000065dc8b4f05ac5bf4007a84704ac675a92b /exec failed with exit code 1
  • pull / cuda12.4-py3.10-gcc9-sm75 / build (gh)
    /usr/include/c++/9/ext/new_allocator.h:146:4: error: no matching function for call to ‘std::pair<const c10::FunctionSchema* const, torch::jit::BoundedShapeGraphs>::pair(const c10::FunctionSchema*&, std::shared_ptr<torch::jit::Graph>&, std::shared_ptr<torch::jit::Graph>&)’
  • pull / linux-focal-cpu-py3.10-gcc11-bazel-test / build-and-test (default, 1, 1, ephemeral.linux.4xlarge) (gh)
    /var/lib/jenkins/workspace/BUILD.bazel:733:11: Compiling torch/csrc/jit/runtime/symbolic_shape_registry.cpp failed: (Exit 1): gcc failed: error executing command (from target //:torch) /opt/cache/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer '-std=c++17' -MD -MF ... (remaining 309 arguments skipped)
  • pull / linux-focal-cuda11.8-py3.10-gcc9 / build (gh)
    /usr/include/c++/9/ext/new_allocator.h:146:4: error: no matching function for call to ‘std::pair<const c10::FunctionSchema* const, torch::jit::BoundedShapeGraphs>::pair(const c10::FunctionSchema*&, std::shared_ptr<torch::jit::Graph>&, std::shared_ptr<torch::jit::Graph>&)’
  • pull / linux-focal-cuda12.6-py3.10-gcc11 / build (gh)
    /usr/include/c++/11/ext/new_allocator.h:162:11: error: no matching function for call to ‘std::pair<const c10::FunctionSchema* const, torch::jit::BoundedShapeGraphs>::pair(const c10::FunctionSchema*&, std::shared_ptr<torch::jit::Graph>&, std::shared_ptr<torch::jit::Graph>&)’
  • pull / linux-focal-cuda12.6-py3.10-gcc11-sm89 / build (gh)
    /usr/include/c++/11/ext/new_allocator.h:162:11: error: no matching function for call to ‘std::pair<const c10::FunctionSchema* const, torch::jit::BoundedShapeGraphs>::pair(const c10::FunctionSchema*&, std::shared_ptr<torch::jit::Graph>&, std::shared_ptr<torch::jit::Graph>&)’
  • pull / linux-focal-py3_9-clang9-xla / build (gh)
    /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/ext/new_allocator.h:150:23: error: no matching constructor for initialization of 'std::pair<const c10::FunctionSchema *const, torch::jit::BoundedShapeGraphs>'
  • pull / linux-focal-py3.13-clang10 / build (gh)
    /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/ext/new_allocator.h:146:23: error: no matching constructor for initialization of 'std::pair<const c10::FunctionSchema *const, torch::jit::BoundedShapeGraphs>'
  • pull / linux-focal-py3.9-clang10 / build (gh)
    /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/ext/new_allocator.h:146:23: error: no matching constructor for initialization of 'std::pair<const c10::FunctionSchema *const, torch::jit::BoundedShapeGraphs>'
  • pull / linux-focal-py3.9-clang10-onnx / build (gh)
    /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/ext/new_allocator.h:146:23: error: no matching constructor for initialization of 'std::pair<const c10::FunctionSchema *const, torch::jit::BoundedShapeGraphs>'
  • pull / linux-focal-rocm-py3.10 / build (gh)
    /usr/include/c++/11/ext/new_allocator.h:162:11: error: no matching function for call to ‘std::pair<const c10::FunctionSchema* const, torch::jit::BoundedShapeGraphs>::pair(const c10::FunctionSchema*&, std::shared_ptr<torch::jit::Graph>&, std::shared_ptr<torch::jit::Graph>&)’
  • pull / linux-jammy-cuda11.8-cudnn9-py3.9-clang12 / build (gh)
    /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:162:23: error: no matching constructor for initialization of 'std::pair<const c10::FunctionSchema *const, torch::jit::BoundedShapeGraphs>'
  • pull / linux-jammy-py3-clang12-executorch / build (gh)
    /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:162:23: error: no matching constructor for initialization of 'std::pair<const c10::FunctionSchema *const, torch::jit::BoundedShapeGraphs>'
  • pull / linux-jammy-py3-clang12-mobile-build / build (gh)
    /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:162:23: error: no matching constructor for initialization of 'std::pair<const c10::FunctionSchema *const, torch::jit::BoundedShapeGraphs>'
  • pull / linux-jammy-py3.10-clang15-asan / build (gh)
    /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:162:23: error: no matching constructor for initialization of 'std::pair<const c10::FunctionSchema *const, torch::jit::BoundedShapeGraphs>'
  • pull / linux-jammy-py3.9-gcc11 / build (gh)
    /usr/include/c++/11/ext/new_allocator.h:162:11: error: no matching function for call to ‘std::pair<const c10::FunctionSchema* const, torch::jit::BoundedShapeGraphs>::pair(const c10::FunctionSchema*&, std::shared_ptr<torch::jit::Graph>&, std::shared_ptr<torch::jit::Graph>&)’
  • pull / linux-jammy-py3.9-gcc11-no-ops / build (gh)
    /usr/include/c++/11/ext/new_allocator.h:162:11: error: no matching function for call to ‘std::pair<const c10::FunctionSchema* const, torch::jit::BoundedShapeGraphs>::pair(const c10::FunctionSchema*&, std::shared_ptr<torch::jit::Graph>&, std::shared_ptr<torch::jit::Graph>&)’
  • pull / linux-jammy-py3.9-gcc11-pch / build (gh)
    /usr/include/c++/11/ext/new_allocator.h:162:11: error: no matching function for call to ‘std::pair<const c10::FunctionSchema* const, torch::jit::BoundedShapeGraphs>::pair(const c10::FunctionSchema*&, std::shared_ptr<torch::jit::Graph>&, std::shared_ptr<torch::jit::Graph>&)’
  • pull / linux-jammy-xpu-2025.0-py3.9 / build (gh)
    /usr/include/c++/11/ext/new_allocator.h:162:11: error: no matching function for call to ‘std::pair<const c10::FunctionSchema* const, torch::jit::BoundedShapeGraphs>::pair(const c10::FunctionSchema*&, std::shared_ptr<torch::jit::Graph>&, std::shared_ptr<torch::jit::Graph>&)’
  • pull / win-vs2022-cpu-py3 / build (gh)
    C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\xmemory(681): error C2661: 'std::pair<const c10::FunctionSchema *const ,torch::jit::BoundedShapeGraphs>::pair': no overloaded function takes 3 arguments

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

  • pull / unstable-linux-focal-cuda12.6-py3.10-gcc11-sm89-xfail / build (gh)
    /usr/include/c++/11/ext/new_allocator.h:162:11: error: no matching function for call to ‘std::pair<const c10::FunctionSchema* const, torch::jit::BoundedShapeGraphs>::pair(const c10::FunctionSchema*&, std::shared_ptr<torch::jit::Graph>&, std::shared_ptr<torch::jit::Graph>&)’

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft February 15, 2025 03:11
@pytorch-bot pytorch-bot bot added NNC release notes: jit release notes category labels Feb 15, 2025
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Feb 15, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Feb 15, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased jit_lint2 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout jit_lint2 && git pull --rebase)

@cyyever cyyever marked this pull request as ready for review February 15, 2025 06:13
@cyyever cyyever changed the title Jit lint2 Fix clang-tidy warnings in torch/jit Feb 15, 2025
@cyyever cyyever requested a review from Skylion007 February 18, 2025 06:02
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 26, 2025
@cyyever cyyever force-pushed the jit_lint2 branch 3 times, most recently from 03e319d to 8e4ace3 Compare May 2, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titaiwangms titaiwangms Awaiting requested review from titaiwangms titaiwangms is a code owner

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1 shubhambhokare1 is a code owner

@Skylion007 Skylion007 Awaiting requested review from Skylion007

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki

Assignees
No one assigned
Labels
NNC oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: jit release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cyyever @pytorchmergebot @Skylion007 @facebook-github-bot @pytorchbot @mikaylagawarecki