Disable cudnn to avoid creating guards that denies exporting #148140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148140
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit da059f1 with merge base 9db9593 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D70357703 |
4b90c32 to
98cd695
Compare
yushangdi
added a commit
to yushangdi/pytorch
that referenced
this pull request
Feb 28, 2025
…#148140) Summary: Fixes pytorch#147623 This code https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/Normalization.cpp#L504-L518 produces guards that raise ConstraintViolation error in batchnorm op. We disable cudnn in export tracing to avoid creating such guards. In the exported graph, the `cudnn_enabled` input to `torch.ops.aten.batch_norm.default` will be False instead of True now. Test Plan: ``` buck2 run mode/dev-nosan //caffe2/test:test_export -- -r bn_dynamic_shapes buck run fbcode//mode/dev-nosan //caffe2/test:test_export -- -r decomp_batch_norm ``` Differential Revision: D70357703
|
This pull request was exported from Phabricator. Differential Revision: D70357703 |
This was referenced Mar 1, 2025
justinchuby
pushed a commit
to microsoft/onnxscript
that referenced
this pull request
Mar 3, 2025
Fixes #2084 This is required to land pytorch/pytorch#148140 in torch.export(). cc @angelayi @@justinchuby Co-authored-by: Shangdi Yu <[email protected]>
yushangdi
added a commit
to yushangdi/pytorch
that referenced
this pull request
Mar 4, 2025
Summary: title required to land pytorch#148140 to include microsoft/onnxscript#2085 Test Plan: CI Differential Revision: D70526777
yushangdi
added a commit
to yushangdi/pytorch
that referenced
this pull request
Mar 4, 2025
Summary: title required to land pytorch#148140 to include microsoft/onnxscript#2085 Test Plan: CI Differential Revision: D70526777
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 4, 2025
Unblock #148140 Pull Request resolved: #148388 Approved by: https://github.com/malfet
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 4, 2025
Unblock #148140 Pull Request resolved: #148388 Approved by: https://github.com/malfet
pytorchmergebot
pushed a commit
to min-jean-cho/pytorch
that referenced
this pull request
Mar 5, 2025
Unblock pytorch#148140 Pull Request resolved: pytorch#148388 Approved by: https://github.com/malfet
98cd695 to
f9bde34
Compare
yushangdi
added a commit
to yushangdi/pytorch
that referenced
this pull request
Mar 5, 2025
…#148140) Summary: Fixes pytorch#147623 This code https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/Normalization.cpp#L504-L518 produces guards that raise ConstraintViolation error in batchnorm op. We disable cudnn in export tracing to avoid creating such guards. In the exported graph, the `cudnn_enabled` input to `torch.ops.aten.batch_norm.default` will be False instead of True now. Test Plan: ``` buck2 run mode/dev-nosan //caffe2/test:test_export -- -r bn_dynamic_shapes buck run fbcode//mode/dev-nosan //caffe2/test:test_export -- -r decomp_batch_norm ``` Differential Revision: D70357703
f9bde34 to
0e1cdf9
Compare
yushangdi
added a commit
to yushangdi/pytorch
that referenced
this pull request
Mar 5, 2025
…#148140) Summary: Fixes pytorch#147623 This code https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/Normalization.cpp#L504-L518 produces guards that raise ConstraintViolation error in batchnorm op. We disable cudnn in export tracing to avoid creating such guards. In the exported graph, the `cudnn_enabled` input to `torch.ops.aten.batch_norm.default` will be False instead of True now. Test Plan: ``` buck2 run mode/dev-nosan //caffe2/test:test_export -- -r bn_dynamic_shapes buck run fbcode//mode/dev-nosan //caffe2/test:test_export -- -r decomp_batch_norm ``` Differential Revision: D70357703
|
This pull request was exported from Phabricator. Differential Revision: D70357703 |
…#148140) Summary: Pull Request resolved: pytorch#148140 Fixes pytorch#147623 This code https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/Normalization.cpp#L504-L518 produces guards that raise ConstraintViolation error in batchnorm op. We disable cudnn in export tracing to avoid creating such guards. In the exported graph, the `cudnn_enabled` input to `torch.ops.aten.batch_norm.default` will be False instead of True now. Test Plan: ``` buck2 run mode/dev-nosan //caffe2/test:test_export -- -r bn_dynamic_shapes buck run fbcode//mode/dev-nosan //caffe2/test:test_export -- -r decomp_batch_norm ``` Differential Revision: D70357703
|
This pull request was exported from Phabricator. Differential Revision: D70357703 |
0e1cdf9 to
da059f1
Compare
angelayi
approved these changes
Mar 5, 2025
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #147623
This code https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/Normalization.cpp#L504-L518 produces guards that raise ConstraintViolation error in batchnorm op.
We disable cudnn in export tracing to avoid creating such guards
Dependency: We need to land microsoft/onnxscript#2085 first in onnxscript, and them bump the onnxscript version in #148388
Test Plan:
Differential Revision: D70357703