[BE][pytree] rename NodeDef member to match the type annotations: *_fn -> *_func
#148474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148474
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6bf30c8 with merge base e9e1aac ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NodeDef member to match the type annotationsNodeDef member to match the type annotations: *_fn -> *_func
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Mar 4, 2025
…*_fn -> *_func` ghstack-source-id: d5c6cc4 Pull Request resolved: pytorch#148474
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Mar 4, 2025
…*_fn -> *_func` ghstack-source-id: d5c6cc4 Pull Request resolved: pytorch#148474
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Mar 12, 2025
…*_fn -> *_func` ghstack-source-id: e43a4e5 Pull Request resolved: pytorch#148474
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Mar 13, 2025
…*_fn -> *_func` ghstack-source-id: 4f6f9e1 Pull Request resolved: pytorch#148474
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Mar 13, 2025
…*_fn -> *_func` ghstack-source-id: 4f6f9e1 Pull Request resolved: pytorch#148474
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Mar 14, 2025
…*_fn -> *_func` ghstack-source-id: f868b48 Pull Request resolved: pytorch#148474
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Mar 31, 2025
…*_fn -> *_func` ghstack-source-id: 2cce41e Pull Request resolved: pytorch#148474
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 1, 2025
…*_fn -> *_func` ghstack-source-id: bffd00d Pull Request resolved: pytorch#148474
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 9, 2025
…*_fn -> *_func` ghstack-source-id: 0bc8be9 Pull Request resolved: pytorch#148474
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 2, 2025
…*_fn -> *_func` ghstack-source-id: 243fdd4 Pull Request resolved: pytorch#148474
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 2, 2025
…*_fn -> *_func` ghstack-source-id: 243fdd4 Pull Request resolved: pytorch#148474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
*_fn -> *_func#148484NodeDefmember to match the type annotations:*_fn -> *_func#148474This PR renames the member in
NodeDeffrom*_fn -> *_func. The old names are aliased to the new names and will emit aFutureWarningwhen accessed.cc @zou3519