update get_default_device to also respect torch.device ctx manager #148621

kshitij12345 · 2025-03-05T23:42:31Z

Fixes #131328

pytorch-bot · 2025-03-05T23:42:35Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148621

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit c3ccbc2 with merge base 5fbaa04 ():
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

⏳ pull / linux-jammy-py3-clang12-executorch / build (gh) (#150261)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kshitij12345 · 2025-04-25T13:02:04Z

Ping @albanD

albanD · 2025-04-29T20:55:24Z

torch/__init__.py

-    if hasattr(_GLOBAL_DEVICE_CONTEXT, "device_context"):
-        device = _GLOBAL_DEVICE_CONTEXT.device_context.device
+    from torch.overrides import _get_current_function_mode_stack
+    from torch.utils._device import DeviceContext


I'm confused now what's the difference between torch._GLOBAL_DEVICE_CONTEXT and torch.utils._device.CURRENT_DEVICE ?
And if we change all access to respect the later, should we just delete the first one?

Currently, I think _GLOBAL_DEVICE_CONTEXT is required to correctly implement the set_default_device with DeviceContext (it holds the DeviceContext object on which enter and exit is called)

pytorch/torch/__init__.py

Lines 1205 to 1218 in ece1658

global _GLOBAL_DEVICE_CONTEXT

if hasattr(_GLOBAL_DEVICE_CONTEXT, "device_context"):

device_context = _GLOBAL_DEVICE_CONTEXT.device_context

if device_context is not None:

device_context.__exit__(None, None, None)

if device is None:

device_context = None

else:

from torch.utils._device import DeviceContext

device_context = DeviceContext(device)

device_context.__enter__()

_GLOBAL_DEVICE_CONTEXT.device_context = device_context

Actually looking at _device.py, I am not sure if CURRENT_DEVICE is needed for implementation.

But I think this (or above) refactoring can be addressed in a separate PR, wdyt?

Gentle ping :)

ppwwyyxx · 2025-05-17T23:21:57Z

Gentle ping :) Running into this bug as well.

kshitij12345 · 2025-06-05T08:03:19Z

@albanD gentle ping :)

ezyang · 2025-06-06T02:33:32Z

@pytorchbot merge

pytorchmergebot · 2025-06-06T02:35:43Z

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#155265

Details for Dev Infra team

Raised by workflow job

kshitij12345 · 2025-06-06T07:22:14Z

@pytorchbot merge

pytorchmergebot · 2025-06-06T07:24:02Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-06-06T07:24:17Z

Merge failed

Reason: 6 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_4-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_6-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_8-build / build, linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-build / build

Details for Dev Infra team

Raised by workflow job

kshitij12345 · 2025-06-06T07:25:27Z

@pytorchbot merge -r

pytorchmergebot · 2025-06-06T07:27:02Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2025-06-06T07:27:06Z

Successfully rebased fix-get-default-device onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix-get-default-device && git pull --rebase)

pytorchmergebot · 2025-06-06T07:28:27Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-06-06T08:31:52Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / Link checks / lint-xrefs / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

kshitij12345 · 2025-06-06T21:03:48Z

@pytorchbot merge -r

pytorchmergebot · 2025-06-06T21:05:23Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2025-06-06T21:05:25Z

Tried to rebase and push PR #148621, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

pytorchmergebot · 2025-06-06T21:05:26Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

kshitij12345 · 2025-06-07T11:39:03Z

@pytorchbot merge -r

pytorchmergebot · 2025-06-07T11:40:41Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2025-06-07T11:40:44Z

Successfully rebased fix-get-default-device onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix-get-default-device && git pull --rebase)

pytorchmergebot · 2025-06-07T11:42:02Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

vadimkantorov · 2025-06-09T12:47:27Z

this PR did not make it into 2.7.1, right?

…ytorch#148621) Fixes pytorch#131328 Pull Request resolved: pytorch#148621 Approved by: https://github.com/ezyang

kshitij12345 added the release notes: python_frontend python frontend release notes category label Mar 5, 2025

kshitij12345 marked this pull request as ready for review March 5, 2025 23:45

kshitij12345 requested a review from ezyang March 5, 2025 23:45

pytorchbot added the open source label Mar 5, 2025

colesbury requested a review from albanD March 6, 2025 18:41

colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 6, 2025

Narsil mentioned this pull request Mar 14, 2025

Always call .to(device) if it was passed as an argument huggingface/safetensors#583

Closed

albanD reviewed Apr 29, 2025

View reviewed changes

ezyang approved these changes Jun 6, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 6, 2025

pytorchmergebot added the merging label Jun 6, 2025

pytorchmergebot removed the merging label Jun 6, 2025

pytorchmergebot added the merging label Jun 6, 2025

pytorchmergebot removed the merging label Jun 6, 2025

pytorchmergebot force-pushed the fix-get-default-device branch from 001abe1 to fcf1b45 Compare June 6, 2025 07:27

pytorchmergebot added the merging label Jun 6, 2025

pytorchmergebot removed the merging label Jun 6, 2025

kshitij12345 added 3 commits June 7, 2025 11:40

update get_default_device to also respect torch.device ctx manager

9c04d45

update name

3c0b910

Update __init__.py

c3ccbc2

pytorchmergebot force-pushed the fix-get-default-device branch from fcf1b45 to c3ccbc2 Compare June 7, 2025 11:40

pytorchmergebot added the merging label Jun 7, 2025

pytorchmergebot added the Merged label Jun 7, 2025

pytorchmergebot closed this in 694028f Jun 7, 2025

pytorchmergebot removed the merging label Jun 7, 2025

vadimkantorov mentioned this pull request Jun 9, 2025

AutoModel.from_pretrained(...) (with explicit device_map unset) fails under with torch.device("meta") with PyTorch 2.6.0 and 2.7.0 huggingface/transformers#38066

Closed

kshitij12345 mentioned this pull request Jul 12, 2025

unxfail passing test Lightning-AI/lightning-thunder#2220

Merged

4 tasks

	global _GLOBAL_DEVICE_CONTEXT
	if hasattr(_GLOBAL_DEVICE_CONTEXT, "device_context"):
	device_context = _GLOBAL_DEVICE_CONTEXT.device_context
	if device_context is not None:
	device_context.__exit__(None, None, None)

	if device is None:
	device_context = None
	else:
	from torch.utils._device import DeviceContext

	device_context = DeviceContext(device)
	device_context.__enter__()
	_GLOBAL_DEVICE_CONTEXT.device_context = device_context

update get_default_device to also respect torch.device ctx manager #148621

update get_default_device to also respect torch.device ctx manager #148621

Uh oh!

Conversation

kshitij12345 commented Mar 5, 2025

Uh oh!

pytorch-bot bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148621

⏳ No Failures, 2 Pending

Uh oh!

kshitij12345 commented Apr 25, 2025

Uh oh!

albanD Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

kshitij12345 Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

kshitij12345 May 6, 2025

Choose a reason for hiding this comment

Uh oh!

ppwwyyxx commented May 17, 2025

Uh oh!

kshitij12345 commented Jun 5, 2025

Uh oh!

ezyang commented Jun 6, 2025

Uh oh!

pytorchmergebot commented Jun 6, 2025

Merge failed

Uh oh!

kshitij12345 commented Jun 6, 2025

Uh oh!

pytorchmergebot commented Jun 6, 2025

Merge started

Uh oh!

pytorchmergebot commented Jun 6, 2025

Merge failed

Uh oh!

kshitij12345 commented Jun 6, 2025

Uh oh!

pytorchmergebot commented Jun 6, 2025

Uh oh!

pytorchmergebot commented Jun 6, 2025

Uh oh!

pytorchmergebot commented Jun 6, 2025

Merge started

Uh oh!

pytorchmergebot commented Jun 6, 2025

Merge failed

Uh oh!

kshitij12345 commented Jun 6, 2025

Uh oh!

pytorchmergebot commented Jun 6, 2025

Uh oh!

pytorchmergebot commented Jun 6, 2025

Uh oh!

pytorchmergebot commented Jun 6, 2025

Uh oh!

kshitij12345 commented Jun 7, 2025

Uh oh!

pytorchmergebot commented Jun 7, 2025

Uh oh!

pytorchmergebot commented Jun 7, 2025

Uh oh!

pytorchmergebot commented Jun 7, 2025

Merge started

Uh oh!

vadimkantorov commented Jun 9, 2025

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 5, 2025 •

edited

Loading