Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[dynamo][invoke_subgraph] Input aliasing and mutation check in Dynamo#148953

Closed
anijain2305 wants to merge 28 commits into
gh/anijain2305/697/basefrom
gh/anijain2305/697/head
Closed

[dynamo][invoke_subgraph] Input aliasing and mutation check in Dynamo#148953
anijain2305 wants to merge 28 commits into
gh/anijain2305/697/basefrom
gh/anijain2305/697/head

Conversation

@anijain2305
Copy link
Copy Markdown
Contributor

@anijain2305 anijain2305 commented Mar 11, 2025 •
edited
Loading

@anijain2305 anijain2305 requested a review from zou3519 as a code owner March 11, 2025 07:05
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148953

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 4 Unrelated Failures

As of commit 6420cb4 with merge base ce54c43 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

anijain2305 added a commit that referenced this pull request Mar 11, 2025
@anijain2305
[dynamo][invoke_subgraph] Use versions to check for input aliasing
4f01e76 
ghstack-source-id: e77333d
Pull Request resolved: #148953
@anijain2305 anijain2305 added the topic: not user facing topic category label Mar 11, 2025
anijain2305
anijain2305 commented Mar 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@anijain2305 anijain2305 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work if a free variable is mutated.

Update - This works now.

@anijain2305 anijain2305 removed the request for review from zou3519 March 11, 2025 17:55
@anijain2305
Update on "[dynamo][invoke_subgraph] Use versions to check for input …
411c214 
…aliasing"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][invoke_subgraph] Use versions to check for input …
719aa8b 
…aliasing"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][invoke_subgraph] Use versions to check for input …
5b36285 
…aliasing"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305 anijain2305 mentioned this pull request Mar 11, 2025
Closed
@anijain2305
Update on "[dynamo][invoke_subgraph] Use versions to check for input …
519c0c5 
…aliasing"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305 anijain2305 mentioned this pull request Mar 12, 2025
Closed
@anijain2305
Update on "[dynamo][invoke_subgraph] Use versions to check for input …
c44688c 
…aliasing"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][invoke_subgraph] Use versions to check for input …
e143788 
…aliasing"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][invoke_subgraph] Use versions to check for input …
98575f5 
…aliasing"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][invoke_subgraph] Use versions to check for input …
742b5cd 
…aliasing"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][invoke_subgraph] Use versions to check for input …
55fb0b1 
…aliasing"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Mar 14, 2025
@anijain2305
[dynamo][invoke_subgraph] Use versions to check for input aliasing
bd37e90 
ghstack-source-id: ffc382a
Pull Request resolved: #148953

[dynamo][invoke_subgraph] Faster aliasing checks

ghstack-source-id: ffc382a
Pull Request resolved: #148997
@anijain2305 anijain2305 changed the title [dynamo][invoke_subgraph] Use versions to check for input aliasing [dynamo][invoke_subgraph] Input aliasing and mutation check in Dynamo Mar 14, 2025
@anijain2305
Update on "[dynamo][invoke_subgraph] Input aliasing and mutation chec…
e2e980c 
…k in Dynamo"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][invoke_subgraph] Input aliasing and mutation chec…
f49b1a4 
…k in Dynamo"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][invoke_subgraph] Input aliasing and mutation chec…
87b83c3 
…k in Dynamo"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][invoke_subgraph] Input aliasing and mutation chec…
7aed2b3 
…k in Dynamo"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
This was referenced Mar 27, 2025
Closed
Closed
zou3519
zou3519 reviewed Mar 27, 2025
View reviewed changes
Comment thread torch/_dynamo/output_graph.py
Comment on lines +2039 to +2041
# Stores the versions of the input tensors at the time they are inserted
# as placeholders in the graph. This is used to track input mutation.
self._input_versions_at_beginning: list[int] = []
Copy link
Copy Markdown
Contributor

@zou3519 zou3519 Mar 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you assert that inference_mode is off here (during Subtracer construction)

Copy link
Copy Markdown
Contributor Author

@anijain2305 anijain2305 Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

zou3519
zou3519 reviewed Mar 27, 2025
View reviewed changes
Comment thread torch/_dynamo/output_graph.py
msg = f"Output-to-output aliasing detected at nodes {output_storages[storage]} and {out_node}"
return AliasingInfo(True, msg)
output_storages[storage] = out_node

Copy link
Copy Markdown
Contributor

@zou3519 zou3519 Mar 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the outputs ever be List[Tensor]? If not, let's assert against it.
(I hope they cannot be List[Tensor], I would want speculate_subgraph to flatten the outputs)

Copy link
Copy Markdown
Contributor Author

@anijain2305 anijain2305 Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Added a test as well.

zou3519
zou3519 reviewed Mar 27, 2025
View reviewed changes
Comment thread torch/_dynamo/output_graph.py
zou3519
zou3519 reviewed Mar 27, 2025
View reviewed changes
Comment thread test/higher_order_ops/test_invoke_subgraph.py
zou3519
zou3519 approved these changes Mar 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but have some minor comments, please read.

@bohnstingl bohnstingl mentioned this pull request Mar 27, 2025
Closed
@anijain2305
Update on "[dynamo][invoke_subgraph] Input aliasing and mutation chec…
a942f6f 
…k in Dynamo"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][invoke_subgraph] Input aliasing and mutation chec…
6420cb4 
…k in Dynamo"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Copy link
Copy Markdown
Contributor Author

anijain2305 commented Mar 28, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 28, 2025
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 28, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 28, 2025

Merge failed

Reason: 3 jobs have failed, first few of them are: linux-binary-libtorch-release / libtorch-cpu-shared-with-deps-release-build / build, linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_6-build / build

Details for Dev Infra team Raised by workflow job

@anijain2305
Copy link
Copy Markdown
Contributor Author

anijain2305 commented Mar 28, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 28, 2025

Merge started

Your change will be merged while ignoring the following 8 checks: pull / cuda12.4-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu), pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.ephemeral.linux.2xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_torchbench, 1, 2, linux.8xlarge.amx), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 1, 2, linux.8xlarge.amx), linux-binary-libtorch-release / libtorch-cpu-shared-with-deps-release-build / build, linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_8-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_6-build / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Mar 28, 2025
@anijain2305 @pytorchmergebot
[inductor] No type promotion for slice_scatter (#150090)
a469ddc 
Pull Request resolved: #150090
Approved by: https://github.com/eellison, https://github.com/zou3519
ghstack dependencies: #149087, #149667, #150036, #148953
amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
@anijain2305 @amathewc
[dynamo][invoke_subgraph] Input aliasing and mutation check in Dynamo (…
1b5aaf3 
…pytorch#148953)

Pull Request resolved: pytorch#148953
Approved by: https://github.com/zou3519
ghstack dependencies: pytorch#149087, pytorch#149667, pytorch#150036
amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
@anijain2305 @amathewc
[inductor] No type promotion for slice_scatter (pytorch#150090)
f5d8c1b 
Pull Request resolved: pytorch#150090
Approved by: https://github.com/eellison, https://github.com/zou3519
ghstack dependencies: pytorch#149087, pytorch#149667, pytorch#150036, pytorch#148953
Divigroup-RAP pushed a commit to Divigroup-RAP/PYTORCH that referenced this pull request Apr 22, 2025
@anijain2305
[dynamo][invoke_subgraph] Use versions to check for input aliasing
e6cd1ae 
ghstack-source-id: 4d85ff1
Pull Request resolved: pytorch/pytorch#148953

[dynamo][invoke_subgraph] Faster aliasing checks

ghstack-source-id: 4d85ff1
Pull Request resolved: pytorch/pytorch#148997
@github-actions github-actions Bot deleted the gh/anijain2305/697/head branch May 2, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

@ydwu4 ydwu4 Awaiting requested review from ydwu4

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anijain2305 @pytorchmergebot @zou3519