[cuDNN][SDPA] cuDNN SDPA refactor/cleanup, nested tensor backward, test priority bump for sm90, sm100
#149282
+980
−415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149282
Note: Links to docs will display an error until the docs builds have been completed. ❌ 15 New Failures, 1 Unrelated FailureAs of commit 7b6fd2d with merge base b027cb8 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchmergebot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
@pytorchmergebot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
ac66884 to
f7c76b8
Compare
|
|
Skylion007
reviewed
Mar 18, 2025
| } | ||
| auto workspace_size = mha_graph->get_workspace_size(); | ||
| auto workspace_ptr = | ||
| c10::cuda::CUDACachingAllocator::get()->allocate(workspace_size); | ||
| TORCH_CHECK( | ||
| mha_graph->execute(handle, variant_pack, workspace_ptr.get()).is_good()); | ||
| mhagraphcache.update(key, graph_and_tensors_values); | ||
| mhagraphcache.update(key, mha_graph); |
There was a problem hiding this comment.
The update method for mhagraphcache should probably use perfect forward up where the update method is defined instead of an lref. And throughout the file should be to remove extra copies.
Suggested change
| mhagraphcache.update(key, mha_graph); | |
| mhagraphcache.update(key, std::move(mha_graph)); |
sm90, sm100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup tuple/tensor boilerplate in cuDNN SDPA, preparation for nested/ragged tensor backward