Thanks to visit codestin.com
Credit goes to github.com

Skip to content

AOTI: add all fallback ops that are missing from C-shim #150673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: gh/benjaminglass1/83/base
Choose a base branch
from
Draft

AOTI: add all fallback ops that are missing from C-shim #150673

wants to merge 13 commits into from

Conversation

benjaminglass1
Copy link
Collaborator

@benjaminglass1 benjaminglass1 commented Apr 4, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Adds all fallback ops that are logged as missing when running the Inductor OpInfo tests with cpp_wrapper mode, with the exception of one or two ops that cannot be currently represented in the C-shim interface.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

@benjaminglass1
Update
5bd608b 
[ghstack-poisoned]
@benjaminglass1 benjaminglass1 mentioned this pull request Apr 4, 2025
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150673

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 Cancelled Jobs

As of commit 4c69d93 with merge base 3849fd1 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@benjaminglass1 benjaminglass1 mentioned this pull request Apr 4, 2025
Closed
@benjaminglass1 benjaminglass1 mentioned this pull request Apr 4, 2025
Closed
benjaminglass1 added a commit that referenced this pull request Apr 4, 2025
@benjaminglass1
AOTI: add all fallback ops that are missing from C-shim
3aa4f8e 
Adds all fallback ops that are logged as missing when running the Inductor OpInfo tests with cpp_wrapper mode, with the exception of one or two ops that cannot be currently represented in the C-shim interface.

ghstack-source-id: d1bdc8a
Pull Request resolved: #150673
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

Attention! PyTorch one of the C-stable API file was changed

You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function.

Caused by:

@benjaminglass1 benjaminglass1 added the topic: not user facing topic category label Apr 4, 2025
@benjaminglass1 benjaminglass1 self-assigned this Apr 4, 2025
@benjaminglass1
Update
9ac6568 
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Apr 7, 2025
@benjaminglass1
AOTI: add all fallback ops that are missing from C-shim
3259352 
Adds all fallback ops that are logged as missing when running the Inductor OpInfo tests with cpp_wrapper mode, with the exception of one or two ops that cannot be currently represented in the C-shim interface.

ghstack-source-id: 3a47f4b
Pull Request resolved: #150673
@benjaminglass1
Update
65f4931 
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Apr 7, 2025
@benjaminglass1
AOTI: add all fallback ops that are missing from C-shim
818247e 
Adds all fallback ops that are logged as missing when running the Inductor OpInfo tests with cpp_wrapper mode, with the exception of one or two ops that cannot be currently represented in the C-shim interface.

ghstack-source-id: 86a024f
Pull Request resolved: #150673
@benjaminglass1
Update
a754c4c 
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Apr 7, 2025
@benjaminglass1
AOTI: add all fallback ops that are missing from C-shim
804f091 
Adds all fallback ops that are logged as missing when running the Inductor OpInfo tests with cpp_wrapper mode, with the exception of one or two ops that cannot be currently represented in the C-shim interface.

ghstack-source-id: 7ab9274
Pull Request resolved: #150673
@benjaminglass1
Update
afef514 
[ghstack-poisoned]
This was referenced Apr 8, 2025
Open
Open
Draft
@benjaminglass1
Update
22f55b1 
[ghstack-poisoned]
@benjaminglass1
Update
6b820e6 
[ghstack-poisoned]
@benjaminglass1
Update
81d5311 
[ghstack-poisoned]
@benjaminglass1
Update
b96e792 
[ghstack-poisoned]
@benjaminglass1 benjaminglass1 added the ciflow/xpu Run XPU CI tasks label Apr 16, 2025
@benjaminglass1
Update
008756d 
[ghstack-poisoned]
@benjaminglass1 benjaminglass1 marked this pull request as ready for review April 17, 2025 02:07
@benjaminglass1
Copy link
Collaborator Author

@desertfire I'm benchmarking this to see if we get any speedups, but I can confirm that we fix a few OpInfo tests running with all the needed fallback ops in place.

@benjaminglass1
Update
7830d83 
[ghstack-poisoned]
Divigroup-RAP pushed a commit to Divigroup-RAP/PYTORCH that referenced this pull request Apr 22, 2025
@benjaminglass1
AOTI: add all fallback ops that are missing from C-shim
af12b63 
Adds all fallback ops that are logged as missing when running the Inductor OpInfo tests with cpp_wrapper mode, with the exception of one or two ops that cannot be currently represented in the C-shim interface.

ghstack-source-id: 252d9df
Pull Request resolved: pytorch/pytorch#150673
@benjaminglass1 benjaminglass1 mentioned this pull request Apr 29, 2025
Open
@benjaminglass1
Update
344bf7f 
[ghstack-poisoned]
@benjaminglass1 benjaminglass1 marked this pull request as draft May 1, 2025 15:33
@benjaminglass1 benjaminglass1 removed the request for review from desertfire May 1, 2025 15:33
@benjaminglass1
Update
4c69d93 
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request May 1, 2025
@benjaminglass1
AOTI: add all fallback ops that are missing from C-shim
0a360a1 
Adds all fallback ops that are logged as missing when running the Inductor OpInfo tests with cpp_wrapper mode, with the exception of one or two ops that cannot be currently represented in the C-shim interface.

ghstack-source-id: f02a475
Pull Request resolved: #150673
@benjaminglass1
Copy link
Collaborator Author

Switched back into draft mode while completing some things agreed with @desertfire offline. This list will be pared back to any fallback ops that complain when doing a benchmarking run, so that we can minimize growth to the AOTI ABI interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@benjaminglass1 benjaminglass1

Labels
ciflow/inductor ciflow/xpu Run XPU CI tasks module: inductor open source release notes: inductor (aoti) topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminglass1 @pytorchbot