Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "[ATen][CUDA] Implement 128 bit vectorization v2 (#145746)" #150679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "[ATen][CUDA] Implement 128 bit vectorization v2 (#145746)" #150679

wants to merge 1 commit into from

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Apr 4, 2025 •
edited
Loading

This reverts commit e84bf88.

This PR caused binary size increase 10% and compile time increase:
#150647
#147376

Proposing to revert this PR and reland together: Optimize 128 bit vectorization #148320

@atalman atalman requested review from eqy and syed-ahmed as code owners April 4, 2025 15:31
@pytorch-bot pytorch-bot bot added the ci-no-td Do not run TD on this PR label Apr 4, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150679

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit dc69435 with merge base 1b0a023 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet
malfet requested changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there are any rush to revert it, we should just figure out how to instantiate those specifically for sm_10 (or sm_12+)

@atalman atalman added the topic: not user facing topic category label Apr 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jun 3, 2025
@github-actions github-actions bot closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet requested changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR Stale topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atalman @malfet