[BE] Add __all__ to torch/nn/functional.pyi and torch/return_types.pyi
#150729
+330
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150729
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e44ca1b with merge base e9e1aac ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 5, 2025
Open
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 5, 2025
…es.pyi` ghstack-source-id: d1097be Pull Request resolved: pytorch#150729
There was a problem hiding this comment.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- torch/_C/return_types.pyi.in: Language not supported
- torch/nn/functional.pyi.in: Language not supported
Comments suppressed due to low confidence (2)
tools/pyi/gen_pyi.py:605
- Consider explicitly using unsorted_dispatched_hints.keys() when extending extra_nn_functional___all__ to make it clear that the keys are being added.
extra_nn_functional___all__.extend(unsorted_dispatched_hints)
tools/pyi/gen_pyi.py:558
- [nitpick] Consider adding a brief comment explaining why 'log_sigmoid' is renamed to 'logsigmoid' to improve code readability.
renamed = {"log_sigmoid": "logsigmoid"}
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 5, 2025
…es.pyi` ghstack-source-id: d8e7ebd Pull Request resolved: pytorch#150729
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 5, 2025
…es.pyi` ghstack-source-id: d8e7ebd Pull Request resolved: pytorch#150729
|
Rebased |
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 7, 2025
…es.pyi` ghstack-source-id: e6f7fe5 Pull Request resolved: pytorch#150729
|
Rebased |
|
Starting merge as part of PR stack under #150732 |
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 9, 2025
…es.pyi` ghstack-source-id: e6f7fe5 Pull Request resolved: pytorch#150729
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 14, 2025
…es.pyi` ghstack-source-id: 95f1870 Pull Request resolved: pytorch#150729
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 14, 2025
…es.pyi` ghstack-source-id: f28293a Pull Request resolved: pytorch#150729
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 26, 2025
…es.pyi` ghstack-source-id: 6d01624 Pull Request resolved: pytorch#150729
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 1, 2025
…es.pyi` ghstack-source-id: 6479909 Pull Request resolved: pytorch#150729
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 2, 2025
…es.pyi` ghstack-source-id: e04d4f2 Pull Request resolved: pytorch#150729
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 2, 2025
…es.pyi` ghstack-source-id: 5b9b691 Pull Request resolved: pytorch#150729
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 2, 2025
…es.pyi` ghstack-source-id: fbe75cc Pull Request resolved: pytorch#150729
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 2, 2025
…es.pyi` ghstack-source-id: 71d621f Pull Request resolved: pytorch#150729
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 2, 2025
…es.pyi` ghstack-source-id: b1807a7 Pull Request resolved: pytorch#150729
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 2, 2025
…es.pyi` ghstack-source-id: 3223b54 Pull Request resolved: pytorch#150729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
lintrunneron generated.pyistub files #150732.pyistub files #150731gen_pyiare properly formatted #150730torch/utils/data/datapipes/gen_pyi.pywithtorchgen#150626__all__totorch/nn/functional.pyiandtorch/return_types.pyi#150729.pyistub template to use Generic TypeAlias (PEP 585) and Union Type (PEP 604) #150728gen_pyi.pyto use Generic TypeAlias (PEP 585) and Union Type (PEP 604) #150727torchgen.utils.FileManagerto acceptpathlib.Path#150726cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki @ezyang @bhosmer @bdhirsh @kadeng