Improve sort with non-constant keys error message #151193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #143505 Test Plan: - new test [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151193
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 05303dd with merge base 1a1a32c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jansel
approved these changes
Apr 14, 2025
|
Starting merge as part of PR stack under #151194 |
anijain2305
approved these changes
Apr 14, 2025
williamwen42
approved these changes
Apr 14, 2025
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 14, 2025
Fixes #151188 Test Plan: - new tests Pull Request resolved: #151194 Approved by: https://github.com/oulgen, https://github.com/anijain2305 ghstack dependencies: #151193
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
Fixes pytorch#143505 Test Plan: - new test Pull Request resolved: pytorch#151193 Approved by: https://github.com/jansel, https://github.com/anijain2305, https://github.com/williamwen42
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
Fixes pytorch#151188 Test Plan: - new tests Pull Request resolved: pytorch#151194 Approved by: https://github.com/oulgen, https://github.com/anijain2305 ghstack dependencies: pytorch#151193
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Fixes pytorch#143505 Test Plan: - new test Pull Request resolved: pytorch#151193 Approved by: https://github.com/jansel, https://github.com/anijain2305, https://github.com/williamwen42
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Fixes pytorch#151188 Test Plan: - new tests Pull Request resolved: pytorch#151194 Approved by: https://github.com/oulgen, https://github.com/anijain2305 ghstack dependencies: pytorch#151193
Divigroup-RAP
pushed a commit
to Divigroup-RAP/PYTORCH
that referenced
this pull request
Apr 22, 2025
Fixes pytorch/pytorch#143505 Test Plan: - new test ghstack-source-id: 536776f Pull Request resolved: pytorch/pytorch#151193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #143505
Test Plan:
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames