inductor.config.descriptive_names = False is not actually supported (#145523) (#146051)#151481
inductor.config.descriptive_names = False is not actually supported (#145523) (#146051)#151481exclamaforte wants to merge 1 commit into
Conversation
…ytorch#145523) (pytorch#146051) Summary: This config is not supported (it throws an error when set), and doesn't really make sense imo. Approved by: https://github.com/eellison Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/edf266e9bbbf6063f7c4a336ffb50234e11a0a82 Reviewed By: masnesral Differential Revision: D68846308
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151481
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 2 Cancelled Jobs, 11 Unrelated FailuresAs of commit 90e4d10 with merge base cd7bc60 ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D68846308 |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -i |
|
will land lintrunner fix on top of this PR #151725 |
Merge startedYour change will be merged while ignoring the following 1 checks: Lint / lintrunner-noclang / linux-job Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "It indeed breaks lint, it followup PR contains it's own issues" -c weird |
|
@pytorchbot successfully started a revert job. Check the current status here. |
…ported (#145523) (#146051) (#151481)" This reverts commit cfc4d74. Reverted #151481 on behalf of https://github.com/malfet due to It indeed breaks lint, it followup PR contains it's own issues ([comment](#151481 (comment)))
|
@exclamaforte your PR has been successfully reverted. |
fixes broken lint tests in #151481 Pull Request resolved: #151725 Approved by: https://github.com/exclamaforte, https://github.com/Skylion007 Co-authored-by: Gabriel Ferns <[email protected]> Co-authored-by: Aaron Gokaslan <[email protected]>
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Summary:
This config is not supported (it throws an error when set), and doesn't really make sense imo.
Approved by: https://github.com/eellison
Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/edf266e9bbbf6063f7c4a336ffb50234e11a0a82
Reviewed By: masnesral
Differential Revision: D68846308
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov