[map] always turn on dynamo for map #152041
Open
+232
−179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152041
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit bf4fbf8 with merge base 8b9c9a3 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D73138427 |
Skylion007
previously approved these changes
Apr 25, 2025
torch/_higher_order_ops/map.py
Outdated
| def map( | ||
| f: Callable[[pytree.PyTree, tuple[pytree.PyTree, ...]], pytree.PyTree], | ||
| xs: Union[pytree.PyTree, torch.Tensor], | ||
| *args, |
There was a problem hiding this comment.
Use a TypeVarTuple for args?
zou3519
approved these changes
Apr 29, 2025
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 2, 2025
Summary: X-link: pytorch/executorch#10409 Reland D72896450 Make map consistent with other control flow ops. After the change, map is able to support accessing closures in the map fn. Test Plan: See existing tests. Reviewed By: zou3519, angelayi Differential Revision: D73138427
|
This pull request was exported from Phabricator. Differential Revision: D73138427 |
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
May 2, 2025
Summary: Reland D72896450 Make map consistent with other control flow ops. After the change, map is able to support accessing closures in the map fn. Test Plan: See existing tests. Reviewed By: zou3519, angelayi Differential Revision: D73138427
|
This pull request was exported from Phabricator. Differential Revision: D73138427 |
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
May 2, 2025
Summary: Reland D72896450 Make map consistent with other control flow ops. After the change, map is able to support accessing closures in the map fn. Test Plan: See existing tests. Reviewed By: zou3519, angelayi Differential Revision: D73138427
|
This pull request was exported from Phabricator. Differential Revision: D73138427 |
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 5, 2025
Summary: Reland D72896450 Make map consistent with other control flow ops. After the change, map is able to support accessing closures in the map fn. Test Plan: See existing tests. Reviewed By: zou3519, angelayi Differential Revision: D73138427
|
This pull request was exported from Phabricator. Differential Revision: D73138427 |
Summary: Reland D72896450 Make map consistent with other control flow ops. After the change, map is able to support accessing closures in the map fn. Test Plan: See existing tests. Reviewed By: zou3519, angelayi Differential Revision: D73138427
|
This pull request was exported from Phabricator. Differential Revision: D73138427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/executorch#10409
Reland D72896450
Make map consistent with other control flow ops. After the change, map is able to support accessing closures in the map fn.
Test Plan: See existing tests.
Reviewed By: zou3519
Differential Revision: D73138427
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames