Switch to standard pep517 sdist generation #152098
Draft
+99
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152098
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 PendingAs of commit 030992c with merge base 3849fd1 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @zklaus could you please add pep517 build as additional source code packaging ? Keeping current tar.gz file as is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate source tarball with PEP 517 conform build tools instead of the custom routine in place right now.
Closes #150461.
The current procedure for generating the source tarball consists in creation of a source tree by manual copying and pruning of source files.
This PR replaces that with a call to the standard build tool, which works with the build backend to produce an sdist. For that to work correctly, the build backend also needs to be configured. In the case of Pytorch, the backend currently is (the legacy version of) the setuptools backend, the source dist part of which is mostly configured via the
MANIFEST.infile.At the moment, this is still a draft due to two issues:
{NAME}-{...}.whlwheels are required to be named{NAME}-{...}.tar.gz. Currently, the source tarball is calledpytorch-{...}.tar.gz, but the generated wheels and python package are calledtorch-{...}.ittapimodule, which can not be resolved by replacing it with a copy.For the first issue, the proposed solution is to distribute the source tarball as
torch-{...}.tar.gz.For the second issue, the best solution would be to eliminate all symbolic links in the source tree. If that is not possible, further investigation is needed. PEP 721 (now integrated in the Source Distribution Format Specification) clarified which kinds of symbolic links are permissible. Possible solutions must be evaluated on a case-by-case basis for every existing symbolic link.
Stack from ghstack (oldest at bottom):