Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ROCm] Maxpool backward NHWC Perf Improvement targeting Resnet scenarios #152267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[ROCm] Maxpool backward NHWC Perf Improvement targeting Resnet scenarios #152267

wants to merge 4 commits into from
+45 −0

Conversation

amd-hhashemi
Copy link
Contributor

@amd-hhashemi amd-hhashemi commented Apr 26, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152267

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs, 2 Unrelated Failures

As of commit a2b578f with merge base e06a080 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch release notes: cuda release notes category labels Apr 26, 2025
@jeffdaily jeffdaily added ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Apr 28, 2025
@pytorch-bot pytorch-bot bot removed ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Apr 28, 2025
@jeffdaily jeffdaily added ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Apr 28, 2025
@jerrymannil jerrymannil mentioned this pull request Apr 29, 2025
Merged
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request Apr 29, 2025
@jerrymannil
[ROCm] Maxpool backward NHWC Perf Improvement targeting Resnet scenar…
af9d084 
…ios (#2060)

Cherry-pick of pytorch#152267
rocm-mici pushed a commit to ROCm/pytorch that referenced this pull request Apr 29, 2025
@jerrymannil
[ROCm] Maxpool backward NHWC Perf Improvement targeting Resnet scenar…
4a6d814 
…ios (#2060)

Cherry-pick of pytorch#152267
@pruthvistony
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased mxpl_bckwrd onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout mxpl_bckwrd && git pull --rebase)

@pytorch-bot pytorch-bot bot removed ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Apr 30, 2025
rocm-mici pushed a commit to ROCm/pytorch that referenced this pull request Apr 30, 2025
@jerrymannil
[ROCm] Maxpool backward NHWC Perf Improvement targeting Resnet scenar…
29c95af 
…ios (#2060)

Cherry-pick of pytorch#152267
okakarpa pushed a commit to ROCm/pytorch that referenced this pull request May 1, 2025
@jerrymannil
[ROCm] Maxpool backward NHWC Perf Improvement targeting Resnet scenar…
c261005 
…ios (#2060)

Cherry-pick of pytorch#152267
jerrymannil added a commit to ROCm/pytorch that referenced this pull request May 2, 2025
@jerrymannil
[ROCm] Maxpool backward NHWC Perf Improvement targeting Resnet scenar…
5df0d92 
…ios (#2060)

Cherry-pick of pytorch#152267
@pruthvistony pruthvistony added ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300 labels May 8, 2025
@amd-hhashemi amd-hhashemi marked this pull request as ready for review May 8, 2025 22:40
@amd-hhashemi amd-hhashemi requested a review from eqy as a code owner May 8, 2025 22:40
@pytorch-bot pytorch-bot bot removed the ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300 label May 9, 2025
@jataylo jataylo added the ciflow/rocm Trigger "default" config CI on ROCm label May 9, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 9, 2025

To add the ciflow label ciflow/rocm please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/rocm Trigger "default" config CI on ROCm label May 9, 2025
@jeffdaily jeffdaily added ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels May 9, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 9, 2025

To add the ciflow label ciflow/rocm please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 9, 2025

To add the ciflow label ciflow/inductor please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 9, 2025

To add the ciflow label ciflow/rocm-mi300 please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 9, 2025

To add the ciflow label ciflow/inductor-rocm please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/inductor-rocm Trigger "inductor" config CI on ROCm labels May 9, 2025
@jeffdaily
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased mxpl_bckwrd onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout mxpl_bckwrd && git pull --rebase)

@jeffdaily jeffdaily added release notes: rocm mandatorylabel ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 and removed release notes: cuda release notes category labels May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@pruthvistony pruthvistony Awaiting requested review from pruthvistony

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

Assignees
No one assigned
Labels
ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 module: rocm AMD GPU support for Pytorch open source release notes: rocm mandatorylabel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amd-hhashemi @pruthvistony @pytorchmergebot @jerrymannil @jeffdaily @pytorchbot @jataylo