Format all headers under ATen/cpu/vec, not just top-level #152364
Conversation
not formatting these seems like an oversight. Had to add a few clang-format suppressions to keep includes in the same order to avoid breaking builds. Differential Revision: [D73802128](https://our.internmc.facebook.com/intern/diff/D73802128/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152364
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit b4cdfab with merge base 81b6920 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D73802128 |
|
@albanD / @seemethere I'm getting yelled at by pr-sanity-checks, which says this PR is too long and I should contact you |
it's generated except for the two small uses of clang-format off/on |
|
Please share the command used to generate the diff so we can skip the pr-sanity-check ! |
lintrunner --paths-cmd "rg --files -g '*.h' aten/src/ATen/cpu/vec/" format |
not formatting these seems like an oversight. Had to add a few clang-format suppressions to keep includes in the same order to avoid breaking builds. Differential Revision: [D73802128](https://our.internmc.facebook.com/intern/diff/D73802128/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 jerryzh168 [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73802128 |
not formatting these seems like an oversight. Had to add a few clang-format suppressions to keep includes in the same order to avoid breaking builds. Differential Revision: [D73802128](https://our.internmc.facebook.com/intern/diff/D73802128/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 jerryzh168 [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73802128 |
|
@albanD can you please advise on the process for bypassing pr-sanity-checks for this PR? (I understand I will need to rebase, but I don't know how we expect to proceed after that) |
|
Added the repro command to the PR description and appropriate label. Should be all good now ! |
not formatting these seems like an oversight. Had to add a few clang-format suppressions to keep includes in the same order to avoid breaking builds. This PR was generated using `lintrunner --paths-cmd "rg --files -g '*.h' aten/src/ATen/cpu/vec/" format` Differential Revision: [D73802128](https://our.internmc.facebook.com/intern/diff/D73802128/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 jerryzh168 albanD [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73802128 |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: Lint / Link checks / lint-urls / linux-job Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
not formatting these seems like an oversight. Had to add a few clang-format suppressions to keep includes in the same order to avoid breaking builds.
This PR was generated using
lintrunner --paths-cmd "rg --files -g '*.h' aten/src/ATen/cpu/vec/" formatDifferential Revision: D73802128
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @albanD