-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Return ConstantVariable(None) from WithExitFunctionVariable.exit to prevent NoneType crash inside autocast exception path #152503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…revent NoneType crash inside autocast exception path
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152503
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dcbb31f with merge base 797768c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@jansel Could you cherry-pick these changes onto the release branch 2.7.1? |
@pytorchbot cherry-pick --onto release/2.7 -c regression |
Cherry picking #152503Command
Details for Dev Infra teamRaised by workflow job |
@jansel Could you please look at these conflicts in the file benchmarks/dynamo/pr_time_benchmarks/expected_results.csv? |
@wdziurdz benchmarks/dynamo/pr_time_benchmarks/expected_results.csv is an autogenerated file. To fix the merge conflicts:
|
@pytorchbot cherry-pick --help |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchbot --help |
PyTorchBot Help
Merge
Revert
Rebase
Label
Dr CI
cherry-pick
Closeusage: @pytorchbot close Close a PR [Can be used on issues] |
…revent NoneType crash inside autocast exception path (pytorch#152503) Copy of pytorch#152013 with PR time benchmarks updated (regressions seem unrelated) Pull Request resolved: pytorch#152503 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 Co-authored-by: Witold Dziurdz <[email protected]>
…revent NoneType crash inside autocast exception path (#153612) Return ConstantVariable(None) from WithExitFunctionVariable.exit to prevent NoneType crash inside autocast exception path (#152503) Copy of #152013 with PR time benchmarks updated (regressions seem unrelated) Pull Request resolved: #152503 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 Co-authored-by: Jason Ansel <[email protected]>
Copy of #152013 with PR time benchmarks updated (regressions seem unrelated)
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames