[BE] Delete Module_CUDA_fix
#152603
Open
[BE] Delete Module_CUDA_fix
#152603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be using upstream find(CUDA) always, shouldn't we?
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152603
Note: Links to docs will display an error until the docs builds have been completed. ❌ 19 New Failures, 1 Unrelated FailureAs of commit 1275724 with merge base 56039b5 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
I recall there are some hacks.. but I prefer having a try |
cyyever
approved these changes
May 1, 2025
|
I think we need to raise the CMake minimum version significantly to do this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be using upstream find(CUDA) always, shouldn't we?