Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update padding_mode type annotation to use Literal type (PaddingMode) #152610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update padding_mode type annotation to use Literal type (PaddingMode) #152610

wants to merge 1 commit into from

Conversation

sudiptap
Copy link

@sudiptap sudiptap commented May 1, 2025 •
edited by mikaylagawarecki
Loading

Fixes #152280

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152610

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit a466f0f with merge base d35e900 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@sudiptap
Copy link
Author

sudiptap commented May 1, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 1, 2025
@sudiptap sudiptap force-pushed the fix/padding-mode-literal-clean branch from 9aee15c to a466f0f Compare May 1, 2025 17:08
@HDCharles HDCharles added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD Awaiting requested review from albanD albanD is a code owner

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees
No one assigned
Labels
open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update torch/nn/modules/conv.py to use Literal for support padding modes
3 participants
@sudiptap @pytorchbot @HDCharles