Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Raise error when no record on extra_files #152664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Raise error when no record on extra_files #152664

wants to merge 3 commits into from

Conversation

ILCSFNO
Copy link
Contributor

@ILCSFNO ILCSFNO commented May 2, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152664

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 1f8be72 with merge base 36e5ff6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label May 2, 2025
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 2, 2025
@ILCSFNO ILCSFNO mentioned this pull request May 2, 2025
Open
@HDCharles HDCharles requested review from davidberard98 and cyyever May 2, 2025 03:49
@HDCharles HDCharles added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 2, 2025
cyyever
cyyever reviewed May 2, 2025
View reviewed changes
torch/csrc/jit/serialization/import.cpp Outdated
@@ -261,6 +261,12 @@ Module ScriptModuleDeserializer::deserialize(
extra_files[kv.first] =
std::string(static_cast<char*>(meta_ptr.get()), meta_size);
}
else {
TORCH_CHECK(
false,
Copy link
Collaborator

@cyyever cyyever May 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace false with the above if condition? Then the if branch could be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyyever Solved by replace, thanks for suggestion!

@cyyever
Copy link
Collaborator

cyyever commented May 2, 2025

@malfet Have a look?

@cyyever cyyever requested a review from malfet May 2, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyyever cyyever cyyever approved these changes

@davidberard98 davidberard98 Awaiting requested review from davidberard98

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: jit release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise an Error when File Not Found in torch.jit.load()
5 participants
@ILCSFNO @cyyever @facebook-github-bot @pytorchbot @HDCharles