set CUDA_MODULE_LOADING for older drivers only #152695
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152695
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 822da20 with merge base 50d4698 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
eqy
reviewed
May 2, 2025
c10/cuda/driver_api.h
Outdated
Comment on lines
53
to
54
| _(nvmlDeviceGetComputeRunningProcesses)\ | ||
| _(nvmlSystemGetCudaDriverVersion_v2) |
There was a problem hiding this comment.
Suggested change
| _(nvmlDeviceGetComputeRunningProcesses)\ | |
| _(nvmlSystemGetCudaDriverVersion_v2) | |
| #if defined(CUDA_VERSION) && !defined(USE_ROCM) | |
| _(nvmlDeviceGetComputeRunningProcesses)\ | |
| #endif | |
| _(nvmlSystemGetCudaDriverVersion_v2) |
malfet
approved these changes
May 2, 2025
|
@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
atalman
approved these changes
May 2, 2025
nWEIdia
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA_MODULE_LOADING=LAZYis the default for all drivers shipped with CUDA >=12.2 and we should check the driver version before setting the env variable.(the
LOG(WARNING)has to be removed before merging)cc @msaroufim @eqy @jerryzh168