Remove redundant type aliases of _device_t for torch.Device (#152952) #153007
+27
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153007
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 2173423 with merge base 5fa5017 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
shink
reviewed
May 7, 2025
| @@ -23,7 +23,7 @@ def empty_cache() -> None: | |||
| torch._C._xpu_emptyCache() | |||
|
|
|||
|
|
|||
| def reset_peak_memory_stats(device: _device_t = None) -> None: | |||
| def reset_peak_memory_stats(device: torch.types.Device = None) -> None: | |||
There was a problem hiding this comment.
Maybe line 10 is no longer needed.
Line 10 in dfcfad2
There was a problem hiding this comment.
Thank you for the review. Will change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152952
This PR removes redundant type aliases for
_device_tand replaces them withtorch.types.Devicewhere applicable, to make the typing system more consistent across PyTorch.cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168