[ONNX] Update decomposition logic to loop over onnx registry #153168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #150367 This PR makes decomposition table from onnx registry, which includes registered ops not only ATen and prim. This will help to keep the custom ops that are specified in the custom_translation table from decomposition during ONNX export. Pull Request resolved: #151826 Approved by: https://github.com/justinchuby (cherry picked from commit 6cd1741)
This was referenced May 8, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153168
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 1 Unrelated FailureAs of commit cf8ade9 with merge base 924a247 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@titaiwangms and @justinchuby could you please provide unit test that covers these changes ? |
|
Hi @atalman thanks for reviewing this! Should we merge the test to main and create another cherry pick for it, or we add the test in this PR? |
pytorchmergebot
pushed a commit
that referenced
this pull request
May 16, 2025
Added a test to strengthen the case for cherry-picking #153168. The original PR didn’t include this test since the fix for decomp_table and the registry was already covered by existing tests. However, it's reasonable to include a dedicated test for the specific issue (#150367 ) when considering the cherry-pick. Pull Request resolved: #153671 Approved by: https://github.com/justinchuby
pytorchbot
pushed a commit
that referenced
this pull request
May 16, 2025
Added a test to strengthen the case for cherry-picking #153168. The original PR didn’t include this test since the fix for decomp_table and the registry was already covered by existing tests. However, it's reasonable to include a dedicated test for the specific issue (#150367 ) when considering the cherry-pick. Pull Request resolved: #153671 Approved by: https://github.com/justinchuby (cherry picked from commit 658d17d)
|
Added a test to strengthen the case for cherry-picking #153168. The original PR didn’t include this test since the fix for decomp_table and the registry was already covered by existing tests. However, it's reasonable to include a dedicated test for the specific issue (#150367 ) when considering the cherry-pick. Pull Request resolved: #153671 Approved by: https://github.com/justinchuby
atalman
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150367
This PR makes decomposition table from onnx registry, which includes registered ops not only ATen and prim. This will help to keep the custom ops that are specified in the custom_translation table from decomposition during ONNX export.