Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reapply "Cleanup VS 2019 refs in pytorch (#145863)" (#152613) #155478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Reapply "Cleanup VS 2019 refs in pytorch (#145863)" (#152613) #155478

wants to merge 2 commits into from

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jun 9, 2025 •
edited
Loading

This reverts commit e4f2282.
I believe fix PR was landed #153480 that triggered the revert.
Hence this is reland.

cc @chuanqi129 @xuhancn

@atalman atalman requested a review from a team as a code owner June 9, 2025 19:14
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155478

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 10adf89 with merge base d4d0ede (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman added the topic: not user facing topic category label Jun 9, 2025
@xuhancn
Copy link
Collaborator

xuhancn commented Jun 9, 2025

LGTM, but I think we'd better add a set of Windows AVX2 UTs to CI, and ensure VS2022 is works well.

@malfet
Copy link
Contributor

malfet commented Jun 10, 2025

LGTM, but I think we'd better add a set of Windows AVX2 UTs to CI, and ensure VS2022 is works well.

I think it should be either AVX512 or AVX2 (unless someone wants to setup Azure runners)

@malfet
Copy link
Contributor

malfet commented Jun 10, 2025

@pytorchbot merge -f "Lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @xuhancn @malfet @pytorchmergebot