Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ONNX] Delete symbolic caffe2#157102

Closed
justinchuby wants to merge 3 commits into
mainfrom
justinchu/onnx-caffe
Closed

[ONNX] Delete symbolic caffe2#157102
justinchuby wants to merge 3 commits into
mainfrom
justinchu/onnx-caffe

Conversation

@justinchuby
Copy link
Copy Markdown
Collaborator

@justinchuby justinchuby commented Jun 27, 2025

Caffe2 is removed from pytorch. This is a clean up.

@justinchuby
[ONNX] Delete symbolic caffe2
408f516 
Caffe2 is removed from pytorch. This is a clean up.

Signed-off-by: Justin Chu <[email protected]>
@pytorch-bot pytorch-bot Bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jun 27, 2025
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jun 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157102

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit b2401dc with merge base 414ad47 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@justinchuby
submodule
623d421 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby added module: onnx Related to torch.onnx topic: bc breaking topic category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) labels Jun 27, 2025
@titaiwangms
Copy link
Copy Markdown
Collaborator

titaiwangms commented Jun 27, 2025

Looks like it still exists: https://github.com/pytorch/pytorch/tree/main/caffe2

justinchuby
justinchuby commented Jun 27, 2025
View reviewed changes
Comment thread docs/source/conf.py
@justinchuby justinchuby removed the request for review from albanD June 27, 2025 22:32
@justinchuby
Copy link
Copy Markdown
Collaborator Author

justinchuby commented Jun 27, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 27, 2025
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 27, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby justinchuby reopened this Jun 27, 2025
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 27, 2025

Merge failed

Reason: 14 jobs have failed, first few of them are: linux-aarch64 / linux-jammy-aarch64-py3.10 / build, linux-binary-manywheel / manywheel-py3_9-cuda12_8-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_9-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_6-build / build, linux-binary-libtorch-release / libtorch-cpu-shared-with-deps-release-build / build

Details for Dev Infra team Raised by workflow job

@justinchuby
Copy link
Copy Markdown
Collaborator Author

justinchuby commented Jun 28, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 28, 2025

Merge started

Your change will be merged while ignoring the following 1 checks: pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby justinchuby deleted the justinchu/onnx-caffe branch June 28, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyyever cyyever cyyever approved these changes

@titaiwangms titaiwangms titaiwangms approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

Assignees

@titaiwangms titaiwangms

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinchuby @titaiwangms @pytorchmergebot @cyyever @pytorchbot