Fix cuda native loss_ctc for varying input length#15798
Closed
t-vi wants to merge 1 commit into
Closed
Conversation
Thank you, @freesouls, for the reproducing example!
Collaborator
Author
|
glad to hear that, hoping for the new release |
soumith
approved these changes
Jan 9, 2019
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jan 9, 2019
Summary: Thank you, freesouls, for the reproducing example! This is strictly fixing the bug in gradients for varying length inputs discussed in the middle-to-bottom of the bug report. I'll have a feature patch regarding inf losses -> NaN grads separately. Fixes: #14401 Pull Request resolved: pytorch/pytorch#15798 Differential Revision: D13605739 Pulled By: soumith fbshipit-source-id: 167ff42399c7e4cdfbd88d59bac5d25b57c0363f
soumith
pushed a commit
that referenced
this pull request
Jan 17, 2019
Summary: Thank you, freesouls, for the reproducing example! This is strictly fixing the bug in gradients for varying length inputs discussed in the middle-to-bottom of the bug report. I'll have a feature patch regarding inf losses -> NaN grads separately. Fixes: #14401 Pull Request resolved: #15798 Differential Revision: D13605739 Pulled By: soumith fbshipit-source-id: 167ff42399c7e4cdfbd88d59bac5d25b57c0363f
soumith
pushed a commit
that referenced
this pull request
Jan 18, 2019
Summary: Thank you, freesouls, for the reproducing example! This is strictly fixing the bug in gradients for varying length inputs discussed in the middle-to-bottom of the bug report. I'll have a feature patch regarding inf losses -> NaN grads separately. Fixes: #14401 Pull Request resolved: #15798 Differential Revision: D13605739 Pulled By: soumith fbshipit-source-id: 167ff42399c7e4cdfbd88d59bac5d25b57c0363f
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Thank you, freesouls, for the reproducing example! This is strictly fixing the bug in gradients for varying length inputs discussed in the middle-to-bottom of the bug report. I'll have a feature patch regarding inf losses -> NaN grads separately. Fixes: pytorch#14401 Pull Request resolved: pytorch#15798 Differential Revision: D13605739 Pulled By: soumith fbshipit-source-id: 167ff42399c7e4cdfbd88d59bac5d25b57c0363f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you, @freesouls, for the reproducing example!
This is strictly fixing the bug in gradients for varying length inputs discussed in the middle-to-bottom of the bug report. I'll have a feature patch regarding inf losses -> NaN grads separately.
Fixes: #14401