Thanks to visit codestin.com
Credit goes to github.com

shape guards#161178

Closed

avikchaudhuri wants to merge 1 commit into

pytorch:mainfrom

avikchaudhuri:export-D80713603

Contributor

avikchaudhuri commented Aug 21, 2025 •

edited by pytorch-bot Bot

Loading

Summary: This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Differential Revision: D80713603

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @ezyang @msaroufim @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela

avikchaudhuri requested review from SherlockNoMad, angelayi, bobrenjc93, laithsakka, tugsbayasgalan, ydwu4 and zhxchen17 as code owners

August 21, 2025 17:29

pytorch-bot Bot commented Aug 21, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161178

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bbf4196 with merge base a92773e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot Bot added ciflow/inductor module: dynamo module: inductor release notes: export labels

facebook-github-bot added the fx label

Contributor

facebook-github-bot commented Aug 21, 2025

This pull request was exported from Phabricator. Differential Revision: D80713603

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Aug 26, 2025

This pull request was exported from Phabricator. Differential Revision: D80713603

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

a422664

Summary:
Pull Request resolved: pytorch#161178

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Differential Revision: D80713603

avikchaudhuri force-pushed the export-D80713603 branch from cdc76c4 to a422664 Compare

August 26, 2025 23:51

pytorch-bot Bot added oncall: distributed release notes: quantization labels

Contributor

facebook-github-bot commented Aug 27, 2025

This pull request was exported from Phabricator. Differential Revision: D80713603

avikchaudhuri force-pushed the export-D80713603 branch from a422664 to cd1f3fa Compare

August 27, 2025 02:22

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

cd1f3fa

Summary:
Pull Request resolved: pytorch#161178

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Differential Revision: D80713603

Contributor

facebook-github-bot commented Aug 27, 2025

This pull request was exported from Phabricator. Differential Revision: D80713603

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

185a89b

Summary:
Pull Request resolved: pytorch#161178

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Differential Revision: D80713603

avikchaudhuri force-pushed the export-D80713603 branch from cd1f3fa to 185a89b Compare

August 27, 2025 02:30

Contributor

facebook-github-bot commented Aug 27, 2025

This pull request was exported from Phabricator. Differential Revision: D80713603

avikchaudhuri force-pushed the export-D80713603 branch from 185a89b to 65c92b0 Compare

August 27, 2025 23:09

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

65c92b0

Summary:
Pull Request resolved: pytorch#161178

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Differential Revision: D80713603

avikchaudhuri added the suppress-bc-linter label

avikchaudhuri force-pushed the export-D80713603 branch from e6d022b to 7e8ff96 Compare

September 6, 2025 07:04

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

7e8ff96

Summary:
Pull Request resolved: pytorch#161178

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Reviewed By: tugsbayasgalan

Differential Revision: D80713603

avikchaudhuri force-pushed the export-D80713603 branch from 7e8ff96 to cbea74a Compare

September 6, 2025 21:05

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

cbea74a

Summary:

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Reviewed By: tugsbayasgalan

Differential Revision: D80713603

Contributor

facebook-github-bot commented Sep 6, 2025

This pull request was exported from Phabricator. Differential Revision: D80713603

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

28dc963

Summary:
Pull Request resolved: pytorch#161178

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Reviewed By: tugsbayasgalan

Differential Revision: D80713603

avikchaudhuri force-pushed the export-D80713603 branch from cbea74a to 28dc963 Compare

September 6, 2025 21:07

Contributor

facebook-github-bot commented Sep 6, 2025

This pull request was exported from Phabricator. Differential Revision: D80713603

avikchaudhuri force-pushed the export-D80713603 branch from 28dc963 to 90d08f3 Compare

September 6, 2025 21:18

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

90d08f3

Summary:
Pull Request resolved: pytorch#161178

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Reviewed By: tugsbayasgalan

Differential Revision: D80713603

avikchaudhuri force-pushed the export-D80713603 branch from 90d08f3 to 6977dbe Compare

September 7, 2025 07:04

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

6977dbe

Summary:

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Reviewed By: tugsbayasgalan

Differential Revision: D80713603

Contributor

facebook-github-bot commented Sep 7, 2025

This pull request was exported from Phabricator. Differential Revision: D80713603

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

43121fa

Summary:
Pull Request resolved: pytorch#161178

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Reviewed By: tugsbayasgalan

Differential Revision: D80713603

avikchaudhuri force-pushed the export-D80713603 branch from 6977dbe to 43121fa Compare

September 7, 2025 07:05

Contributor

facebook-github-bot commented Sep 7, 2025

This pull request was exported from Phabricator. Differential Revision: D80713603

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

16b9872

Summary:
Pull Request resolved: pytorch#161178

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Reviewed By: tugsbayasgalan

Differential Revision: D80713603

avikchaudhuri force-pushed the export-D80713603 branch 2 times, most recently from 16b9872 to 49b65ca Compare

September 8, 2025 15:48

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

49b65ca

Summary:

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Reviewed By: tugsbayasgalan

Differential Revision: D80713603

Contributor

facebook-github-bot commented Sep 8, 2025

This pull request was exported from Phabricator. Differential Revision: D80713603

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          shape guards (pytorch#161178)

Summary:
Pull Request resolved: pytorch#161178

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Reviewed By: tugsbayasgalan

Differential Revision: D80713603

avikchaudhuri force-pushed the export-D80713603 branch from 49b65ca to 0777338 Compare

September 8, 2025 15:52


          shape guards (pytorch#161178)

bbf4196

Summary:
Pull Request resolved: pytorch#161178

This PR introduces shape guards to export. Previously only value ranges,  equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.

Test Plan:
updated several tests

Rollback Plan:

Reviewed By: tugsbayasgalan

Differential Revision: D80713603

Contributor

facebook-github-bot commented Sep 8, 2025

This pull request was exported from Phabricator. Differential Revision: D80713603

avikchaudhuri force-pushed the export-D80713603 branch from 0777338 to bbf4196 Compare

September 8, 2025 16:05

Contributor Author

avikchaudhuri commented Sep 8, 2025

@pytorchbot merge

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Sep 8, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yushangdi yushangdi left review comments

pianpwk pianpwk left review comments

tugsbayasgalan tugsbayasgalan approved these changes

bobrenjc93 Awaiting requested review from bobrenjc93

laithsakka Awaiting requested review from laithsakka

SherlockNoMad Awaiting requested review from SherlockNoMad SherlockNoMad is a code owner

zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

angelayi Awaiting requested review from angelayi angelayi is a code owner

Labels

ciflow/inductor ciflow/trunk fb-exported fx Merged module: dynamo module: inductor oncall: distributed release notes: export release notes: inductor (aoti) release notes: quantization suppress-bc-linter