[ONNX] Drop draft_export in exporter API#161454
Closed
titaiwangms wants to merge 3 commits into
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161454
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 94ffaa7 with merge base ca9fe01 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
justinchuby
reviewed
Aug 26, 2025
justinchuby
approved these changes
Aug 26, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 2 jobs have failed, first few of them are: trunk / win-vs2022-cuda12.6-py3 / build, trunk / win-vs2022-cpu-py3 / build Details for Dev Infra teamRaised by workflow job |
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 5, 2025
Use `TORCH_ONNX_ENABLE_DRAFT_EXPORT` to control whether draft_export should be used as a strategy in onnx export. Follow up of #161454 Pull Request resolved: #162225 Approved by: https://github.com/xadupre, https://github.com/titaiwangms
daisyden
pushed a commit
to daisyden/pytorch
that referenced
this pull request
Sep 8, 2025
Use `TORCH_ONNX_ENABLE_DRAFT_EXPORT` to control whether draft_export should be used as a strategy in onnx export. Follow up of pytorch#161454 Pull Request resolved: pytorch#162225 Approved by: https://github.com/xadupre, https://github.com/titaiwangms
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
If onnx exporter fallbacks to draft_export with big models, this is taking forever for users, and possibly spam the printout, which keeps users from their stack trace with strict=False. We could consider make another API for draft_export as debugging tool, or combine it with report=True when "model is small"? Pull Request resolved: pytorch#161454 Approved by: https://github.com/justinchuby
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Use `TORCH_ONNX_ENABLE_DRAFT_EXPORT` to control whether draft_export should be used as a strategy in onnx export. Follow up of pytorch#161454 Pull Request resolved: pytorch#162225 Approved by: https://github.com/xadupre, https://github.com/titaiwangms
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
Use `TORCH_ONNX_ENABLE_DRAFT_EXPORT` to control whether draft_export should be used as a strategy in onnx export. Follow up of pytorch#161454 Pull Request resolved: pytorch#162225 Approved by: https://github.com/xadupre, https://github.com/titaiwangms
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
Use `TORCH_ONNX_ENABLE_DRAFT_EXPORT` to control whether draft_export should be used as a strategy in onnx export. Follow up of pytorch#161454 Pull Request resolved: pytorch#162225 Approved by: https://github.com/xadupre, https://github.com/titaiwangms
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
Use `TORCH_ONNX_ENABLE_DRAFT_EXPORT` to control whether draft_export should be used as a strategy in onnx export. Follow up of pytorch#161454 Pull Request resolved: pytorch#162225 Approved by: https://github.com/xadupre, https://github.com/titaiwangms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If onnx exporter fallbacks to draft_export with big models, this is taking forever for users, and possibly spam the printout, which keeps users from their stack trace with strict=False.
We could consider make another API for draft_export as debugging tool, or combine it with report=True when "model is small"?
cc @justinchuby