Fix slogdet sign requiring grad when input requires grad#16337
Closed
ssnl wants to merge 1 commit into
Closed
Conversation
soumith
approved these changes
Jan 27, 2019
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: The real fix for pytorch#15605. This is sort of BC breaking because now ```py In [1]: import torch In [2]: a = torch.randn(3, 3, requires_grad=True) In [3]: a.slogdet() Out[3]: (tensor(1.), tensor(0.1356, grad_fn=<SlogdetBackward>)) In [4]: a.slogdet()[0].requires_grad Out[4]: False ``` while before this patch ` a.slogdet()[0]` requires grad with `grad_fn=<SlogdetBackward>`. But any use of backproping through this value will meet the error in pytorch#15605 so I don't think this is a problem. Pull Request resolved: pytorch#16337 Differential Revision: D13832644 Pulled By: soumith fbshipit-source-id: f96c477e99edcbdbd966888e5c5ea7fd058429a8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real fix for #15605.
This is sort of BC breaking because now
while before this patch
a.slogdet()[0]requires grad withgrad_fn=<SlogdetBackward>. But any use of backproping through this value will meet the error in #15605 so I don't think this is a problem.