[doc] add example multiprocess code#16345
Closed
ailzhang wants to merge 3 commits into
Closed
Conversation
ezyang
reviewed
Jan 25, 2019
|
|
||
| p.join() | ||
|
|
||
| `q` and `e` are used to coordinate between sender and receiver processes. |
Contributor
There was a problem hiding this comment.
I think it would be clearer here if we briefly explained why we need the e before diving into the mechanics. We could also make this even more explicit in the code by deleting s_sample when the wait comes back.
The other subtlety, which I recall you telling me about, is that you have to actually delete the tensor, it's not enough to not use it anymore. That's also worth explicitly calling out here.
Contributor
Author
|
@ezyang another review on this? :D |
Contributor
Author
|
Thanks @ezyang ! |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 30, 2019
Summary: fixes #16141 Differential Revision: D13868539 Pulled By: ailzhang fbshipit-source-id: 03e858d0aff7804c5e9e03a8666f42fd12836ef2
Contributor
Author
|
This is already landed on master. Closing. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: fixes pytorch#16141 Differential Revision: D13868539 Pulled By: ailzhang fbshipit-source-id: 03e858d0aff7804c5e9e03a8666f42fd12836ef2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16141
cc: @ezyang @colesbury