Honor $XDG_CACHE_HOME in C++ code of DebugInfoWriter#168232
Closed
Flamefire wants to merge 2 commits into
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168232
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit acb6a53 with merge base 3b19eca ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
In other places, e.g. Python code, "~/.cache/torch" is only used as fallback of "$XDG_CACHE_HOME/torch". So honor it here too.
d1a0bb1 to
373f003
Compare
ezyang
reviewed
Nov 21, 2025
| #endif | ||
| std::string cacheRoot; | ||
| if (cacheHome) | ||
| cacheRoot = cacheHome; |
Collaborator
Author
There was a problem hiding this comment.
Done. Wasn't sure if they should be used for single line blocks.
ezyang
approved these changes
Dec 29, 2025
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
krastogi-in
pushed a commit
to krastogi-in/pytorch
that referenced
this pull request
Jan 9, 2026
In other places, e.g. Python code, "~/.cache/torch" is only used as fallback of "$XDG_CACHE_HOME/torch". So honor it here too. This avoids issues where $HOME is not set or not writable. Pull Request resolved: pytorch#168232 Approved by: https://github.com/ezyang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In other places, e.g. Python code, "~/.cache/torch" is only used as fallback of "$XDG_CACHE_HOME/torch".
So honor it here too.
This avoids issues where $HOME is not set or not writable.