Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move argsort to C++#17099

Closed
zasdfgbnm wants to merge 6 commits into
pytorch:masterfrom
zasdfgbnm:argsort
Closed

Move argsort to C++#17099
zasdfgbnm wants to merge 6 commits into
pytorch:masterfrom
zasdfgbnm:argsort

Conversation

@zasdfgbnm
Copy link
Copy Markdown
Collaborator

No description provided.

@gchanan
Copy link
Copy Markdown
Contributor

gchanan commented Feb 20, 2019

looks like you hit a merge conflict.

@zasdfgbnm
Copy link
Copy Markdown
Collaborator Author

@gchanan resolved

@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Feb 21, 2019

@pytorchbot rebase this please

@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Feb 21, 2019

Verified that the previous docs were wrong:

>>> torch.sort(torch.randn(3), dim=None)                                     
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: sort(): argument 'dim' must be int, not NoneType                  
>>> torch.sort(torch.randn(3), dim=-1)                                       
(tensor([-0.8905,  0.3219,  1.4383]), tensor([0, 1, 2])) 

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zasdfgbnm zasdfgbnm deleted the argsort branch February 21, 2019 17:26
zdevito pushed a commit to zdevito/ATen that referenced this pull request Feb 21, 2019
Summary: Pull Request resolved: pytorch/pytorch#17099

Differential Revision: D14165671

Pulled By: ezyang

fbshipit-source-id: 3871de6874fe09871ebd9b8943c13c9af325bf33
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary: Pull Request resolved: pytorch#17099

Differential Revision: D14165671

Pulled By: ezyang

fbshipit-source-id: 3871de6874fe09871ebd9b8943c13c9af325bf33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants