Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Correct loss docstrings#17300

Closed
ZhuBaohe wants to merge 9 commits into
pytorch:masterfrom
ZhuBaohe:lossdoc
Closed

Correct loss docstrings#17300
ZhuBaohe wants to merge 9 commits into
pytorch:masterfrom
ZhuBaohe:lossdoc

Conversation

@ZhuBaohe
Copy link
Copy Markdown
Contributor

In the loss doc description, replace the deprecated 'reduct' and 'size_average' parameters with the 'reduction' parameter.

@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Feb 20, 2019

You're going to have to fix lint.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@soumith
Copy link
Copy Markdown
Collaborator

soumith commented Feb 23, 2019

thank you @ZhuBaohe !

@soumith
Copy link
Copy Markdown
Collaborator

soumith commented Feb 28, 2019

@pytorchbot rebase this please

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ZhuBaohe ZhuBaohe deleted the lossdoc branch March 11, 2019 01:50
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
In the loss doc description, replace the deprecated 'reduct' and 'size_average' parameters with the 'reduction' parameter.
Pull Request resolved: pytorch#17300

Differential Revision: D14195789

Pulled By: soumith

fbshipit-source-id: 625e650ec20f13b2d22153a4a535656cf9c8f0eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants