Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ONNX Export Argmin and Argmax ops#17382

Closed
lara-hdr wants to merge 3 commits into
pytorch:masterfrom
lara-hdr:lahaidar/onnx_export_argmax
Closed

ONNX Export Argmin and Argmax ops#17382
lara-hdr wants to merge 3 commits into
pytorch:masterfrom
lara-hdr:lahaidar/onnx_export_argmax

Conversation

@lara-hdr
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the failed CI is caused by the infra error. Please rebase to master since we already bump up the onnx version and producer version.

@lara-hdr lara-hdr force-pushed the lahaidar/onnx_export_argmax branch from 64b29ac to 3b467f7 Compare February 27, 2019 01:01
@lara-hdr
Copy link
Copy Markdown
Contributor Author

@houseroad is the pr/py2-devtoolset7-rocmrpm-centos7.5 failure something I should invest time in investigating?

@houseroad
Copy link
Copy Markdown
Member

@lara-hdr no, I think it's infra error. I have restarted it.

Copy link
Copy Markdown
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lara-hdr
Copy link
Copy Markdown
Contributor Author

lara-hdr commented Mar 5, 2019

@houseroad would it be possible to merge this if there are no other comments?
thanks!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary: Pull Request resolved: pytorch#17382

Differential Revision: D14338811

Pulled By: houseroad

fbshipit-source-id: be07548d8063d1aa94f1801c18137738365b85fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants