Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ellipsis in subscript#17763

Closed
Krovatkin wants to merge 2 commits into
pytorch:masterfrom
Krovatkin:krovatkin/ellipsis
Closed

Ellipsis in subscript#17763
Krovatkin wants to merge 2 commits into
pytorch:masterfrom
Krovatkin:krovatkin/ellipsis

Conversation

@Krovatkin
Copy link
Copy Markdown
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 7, 2019
@Krovatkin
Copy link
Copy Markdown
Contributor Author

Krovatkin commented Mar 8, 2019

#17389

tagging @zdevito for a quick progress update: I had very little time to work on this last week and most of this week. I should move faster from now on given that my bootcamp journey is over now.

@Krovatkin Krovatkin requested a review from zdevito March 9, 2019 00:17
@Krovatkin Krovatkin changed the title [WIP] Towards enabling ellipsis in slices Ellipsis in subscript Mar 9, 2019
@Krovatkin Krovatkin force-pushed the krovatkin/ellipsis branch from c59effd to 8f446bf Compare March 9, 2019 00:26
@zdevito zdevito requested review from suo and removed request for zdevito March 11, 2019 23:43
Comment thread torch/csrc/jit/script/compiler.cpp Outdated
@Krovatkin Krovatkin force-pushed the krovatkin/ellipsis branch 3 times, most recently from a84469d to 2f1109b Compare March 22, 2019 22:40
@Krovatkin Krovatkin requested a review from suo March 22, 2019 22:44
Copy link
Copy Markdown
Member

@suo suo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, but try rebasing past the test failures before landing

@Krovatkin Krovatkin force-pushed the krovatkin/ellipsis branch 3 times, most recently from e4970d9 to ccf9d3a Compare April 9, 2019 22:46
@Krovatkin Krovatkin force-pushed the krovatkin/ellipsis branch from 20683c4 to c6211a9 Compare April 10, 2019 20:24
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

fix python 3 failures

python 3 fixes
@Krovatkin Krovatkin force-pushed the krovatkin/ellipsis branch from c6211a9 to ea3dc50 Compare April 15, 2019 16:46
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krovatkin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@Krovatkin merged this pull request in ada10ad.

zhangguanheng66 pushed a commit to zhangguanheng66/pytorch that referenced this pull request May 6, 2019
Summary: Pull Request resolved: pytorch#17763

Differential Revision: D14893533

Pulled By: Krovatkin

fbshipit-source-id: c46b4e386d3aa30e6dc03e3052d2e5ff097fa74b
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary: Pull Request resolved: pytorch#17763

Differential Revision: D14893533

Pulled By: Krovatkin

fbshipit-source-id: c46b4e386d3aa30e6dc03e3052d2e5ff097fa74b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants