Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Profiler] Add a deprecation warning for metadata_json#179417

Closed
ryanzhang22 wants to merge 1 commit into
pytorch:mainfrom
ryanzhang22:expose-extra-meta
Closed

[Profiler] Add a deprecation warning for metadata_json#179417
ryanzhang22 wants to merge 1 commit into
pytorch:mainfrom
ryanzhang22:expose-extra-meta

Conversation

@ryanzhang22
Copy link
Copy Markdown
Contributor

@ryanzhang22 ryanzhang22 commented Apr 5, 2026 •
edited
Loading

Adds a deprecation warning for metadata_json, as we want to move away from using JSON as the default output for all things profiler and the info here is duplicated with event_metadata. I made it a property so that the warning prints when someone tries to use it.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 5, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/179417

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 4dcffe4 with merge base 296c570 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 5, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@ryanzhang22
Copy link
Copy Markdown
Contributor Author

ryanzhang22 commented Apr 6, 2026

@pytorchbot rebase

@ryanzhang22 ryanzhang22 marked this pull request as ready for review April 6, 2026 13:34
@ryanzhang22 ryanzhang22 requested a review from scotts as a code owner April 6, 2026 13:34
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Apr 6, 2026

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Apr 6, 2026

Successfully rebased expose-extra-meta onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout expose-extra-meta && git pull --rebase)

@ryanzhang22 ryanzhang22 force-pushed the expose-extra-meta branch 2 times, most recently from 82c6160 to b427a40 Compare April 13, 2026 11:47
@ryanzhang22 ryanzhang22 changed the title [Profiler] Expose raw_metadata and add a deprecation warning for metadata_json [Profiler] Add a deprecation warning for metadata_json Apr 13, 2026
@scotts scotts added the topic: deprecation topic category label Apr 13, 2026
@ryanzhang22
Copy link
Copy Markdown
Contributor Author

ryanzhang22 commented Apr 13, 2026

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Apr 13, 2026

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Apr 13, 2026

Tried to rebase and push PR #179417, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@ryanzhang22
Copy link
Copy Markdown
Contributor Author

ryanzhang22 commented Apr 14, 2026

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Apr 14, 2026

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Apr 14, 2026

Successfully rebased expose-extra-meta onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout expose-extra-meta && git pull --rebase)

@ryanzhang22
Copy link
Copy Markdown
Contributor Author

ryanzhang22 commented Apr 14, 2026

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 14, 2026
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Apr 14, 2026

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 14, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@ryanzhang22 ryanzhang22 added the release notes: profiler release notes category label Apr 14, 2026
@ryanzhang22
Copy link
Copy Markdown
Contributor Author

ryanzhang22 commented Apr 14, 2026

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Apr 14, 2026

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BoyuanFeng pushed a commit that referenced this pull request Apr 15, 2026
@ryanzhang22 @BoyuanFeng
[Profiler] Add a deprecation warning for metadata_json (#179417)
a26150a 
Adds a deprecation warning for `metadata_json`, as we want to move away from using JSON as the default output for all things profiler and the info here is duplicated with `event_metadata`. I made it a property so that the warning prints when someone tries to use it.
Pull Request resolved: #179417
Approved by: https://github.com/scotts
pytorchmergebot pushed a commit to scotts/pytorch that referenced this pull request Apr 15, 2026
@ryanzhang22 @pytorchmergebot
[Profiler] Add a deprecation warning for metadata_json (pytorch#179417)
186b145 
Adds a deprecation warning for `metadata_json`, as we want to move away from using JSON as the default output for all things profiler and the info here is duplicated with `event_metadata`. I made it a property so that the warning prints when someone tries to use it.
Pull Request resolved: pytorch#179417
Approved by: https://github.com/scotts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scotts scotts scotts approved these changes

@divyanshk divyanshk Awaiting requested review from divyanshk

@jiannanWang jiannanWang Awaiting requested review from jiannanWang

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: profiler release notes category topic: deprecation topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanzhang22 @pytorchmergebot @scotts