[CI] Add --no-install-recommends to clang >= 18 install#180133
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/180133
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 63 PendingAs of commit e8520ca with merge base 6222661 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The clang >= 18 apt-get path was missing --no-install-recommends (unlike the older clang path), which pulled in llvm-18-dev (~428 MB) as a recommended dependency of clang-18. The dev package is not needed for CI builds. This brings the install_clang layer from 877 MB to 449 MB. Authored with Claude. ghstack-source-id: a9c0dda Pull-Request: #180133
|
@pytorchbot merge -f "Let's test it in trunk" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
)" This reverts commit 43feab2. Reverted #180133 on behalf of https://github.com/huydhn due to I think this detects a leak in trunk and fails ([comment](#180130 (comment)))
|
@pytorchbot merge -f "Let's test in prod" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
The apt valgrind (3.18.1 on jammy) is sufficient for PyTorch's usage (primarily callgrind-based instruction counting in benchmarks). Building 3.20.0 from source also pulled in unnecessary build deps (asciidoc, docbook-xml, docbook-xsl, xsltproc). This saves ~130 MB in the install_base Docker layer and ~70s of build time. Added suppression for dlopen false-positive, that were fixed in https://sourceware.org/git/?p=valgrind.git;a=commit;h=947388eb043ea1c44b37df94046e1eee790ad776 Authored with Claude. Pull Request resolved: #180130 Approved by: https://github.com/Skylion007 ghstack dependencies: #180133
) Run git clone, git checkout, and python install.py as the jenkins user directly (via as_jenkins/conda_run), matching the pattern used by install_huggingface() and install_timm() in the same file. This removes two expensive recursive chown calls on the torchbench dir and /opt/conda. Authored with Claude. Pull Request resolved: #180180 Approved by: https://github.com/Skylion007 ghstack dependencies: #180133, #180130
Stack from ghstack (oldest at bottom):
The clang >= 18 apt-get path was missing
--no-install-recommends, which pulled in llvm-18-dev (~428 MB) as arecommended dependency of clang-18. The dev package is not needed for CI builds. This brings the install_clang layer from 877 MB to 449 MB.
Authored with Claude.