[ONNX] Support dim=None for argmax and argmin#18264
Closed
zasdfgbnm wants to merge 3 commits into
Closed
Conversation
houseroad
previously requested changes
Mar 21, 2019
Member
houseroad
left a comment
There was a problem hiding this comment.
Thanks for adding this support.
Please don't use expect files to test in this case.
Check test/onnx/test_pytorch_onnx_caffe2.py, and do it end to end. :-)
Collaborator
Author
|
@houseroad Done |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@houseroad merged this pull request in bf2a30c. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Fixes: pytorch#18263 cc: houseroad Pull Request resolved: pytorch#18264 Reviewed By: ezyang Differential Revision: D14559234 Pulled By: houseroad fbshipit-source-id: c5b8623752d6c6af41c6d715fd9585a65294868d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #18263
cc: @houseroad